move @inlang/core/fs back to @inlang/core/config

[samuelstroschein]

Problem

@openscript as part of https://github.com/orgs/inlang/discussions/373, we moved fs into its own directory and defined exports for @inlang/core/fs.

I remember now why I used typeof fs, I don't expect @inlang/core to contain an implementation of fs. @inlang/core defines the API for an environment function $fs. The underlying implementation is external e.g. node, vscode, or a browser implementation. The browser implementation we will likely develop as part of @inlang/git-sdk or @inlang/fs but not core itself.

Proposal

Move fs back to config and prefix it with $ again to signal this is an environment function that is passed to the "environment" and implemented externally.

[samuelstroschein]

Or, we could move environment functions out of config into environment-functions or env.

[openscript]

I also support this

[samuelstroschein]

@ivanhofer @nikitavoloboev thoughts?

[ivanhofer]

agree

[nikitavoloboev]

I haven’t used environment functions or env as much to really have an opinion but this sounds reasonable.

[samuelstroschein]

Okay, will implement this tomorrow as part of #436

[openscript]

sounds reasonable as it is no implementation of an FS and just types

[samuelstroschein]

closed in #471