New options for the CLI

[WarningImHack3r]

I'd love to see a new option and a new subcommand:

• npx @inlang/cli config upgrade --match-sdk-version: this option would, as its name implies, upgrade all plugins to their latest versions but keep the sdk-js-plugin to the same version as the one currently installed in the package.json file. I already made this script myself, but I'd much prefer this to be built-in. It could optionally be matching the version pattern instead of being the exact same version, so that the runtime version bumper can be easily reused.
• npx @inlang/cli lint fix: this subcommand (or option) would be used to automatically fix most of the problems reported by the lint rules instead of simply reporting the errors. I've never had a wrong config since I discovered this command, but I assume this is its current behavior.
  I'm aware it would lead to major changes in the process of creating your own lint rules, but I think it's worth it and could even be optional to not become a breaking change.

[samuelstroschein]

@WarningImHack3r thanks for the request.

Regarding version upgrade of plugins

@inlang/sdk-js don't we have a mechanism that keeps the SDK plugin and SDK package.json version in sync?

Regarding lint --fix

Yes, should come. But, requires an addition to the lint system that enables rules to fix things. Will come eventually!

[WarningImHack3r]

Yes it indeed works but it only runs at run time, I cannot trigger it without running Vite. Is this system going to be adapted to be used in the config upgrade command, or in the new module update command as discussed in #1238?

[ivanhofer]

Yes it indeed works but it only runs at run time, I cannot trigger it without running Vite

Before the vite process runs, you don't need to have the version updated as only the vite-plugin interacts with that module.

Is this system going to be adapted to be used in the config upgrade command, or in the new module update command as discussed in #1238?

If we would update it, we would also need to update the npm package, or else it does not make sense.

[WarningImHack3r]

Let me explain better:
The SDK version in the config file needs to be the same as the installed SDK NPM package, we all agree with that.
To handle that, we currently face 2 options: waiting for the Vite process to upgrade it (thus modifying an out-of-date config), or making sure that they both are identical (NPM & config) each time we upgrade the NPM version.

I don't really like the first option, because a Vite-dependent config upgrade translates to a dirty file in the local codebase, which isn't clean. It's okay for a dev-time temporary upgrade, not for a long-term clean sync between NPM & config.

That's why I created the script I linked above in my CI: every time some code is pushed, the script is run and the config is automatically updated to reflect the NPM version. If a config bump occurs, the new config is instantly pushed into the PR we're working on. This way, the codebase is always clean and the versions are always synced.

However, I noticed recently while looking for something else in your docs that the config upgrade command was a thing. I thought this was great because it would basically replace my dedicated script, and also makes sure that the 2 other imports I make in my config are also up-to-date.
The problem is that this command bumps everything to the latest version, and consequently the SDK regardless of the installed NPM version.

That's why I'm requesting this option, to be able to get rid of my script but keep the advantages of a "clean codebase" and always synced versions.

As we discussed in #1238, this might come in another form (module update, which will be essentially the same if I understood well), but an Inlang-provided solution sounds good anyway.

Also, as mentioned in #1229, I would preferably want it to use the exact same version, not having a patch-version difference regardless of the selector in package.json. I want to be sure that I run a version that I'm sure it's working to avoid dealing with potential inconsistencies and version mismatches (even though I never ran into this kind of issue before).

Hoping this will make its way into a feature!

[ivanhofer]

I don't really like the first option, because a Vite-dependent config upgrade translates to a dirty file in the local codebase, which isn't clean. It's okay for a dev-time temporary upgrade, not for a long-term clean sync between NPM & config.

As explained above, from a functional perspective, this will never be an issue and will not cause into bugs. It just is not 100% clean.

The problem is that this command bumps everything to the latest version, and consequently the SDK regardless of the installed NPM version.

Yes this is a bug and sdk-plugin should not have the same update logic as all other modules.

As we discussed in #1238, this might come in another form (module update, which will be essentially the same if I understood well), but an Inlang-provided solution sounds good anyway.

The npx @inlang/cli config update cli command will be removed but we could expose the sdk-plugin upgrade function in @inlang/sdk-js so for now you can manually call it when needed.

Also, as mentioned in #1229, I would preferably want it to use the exact same version, not having a patch-version difference regardless of the selector in package.json. I want to be sure that I run a version that I'm sure it's working to avoid dealing with potential inconsistencies and version mismatches (even though I never ran into this kind of issue before).

As already described in #1229 (comment), the upgrade command uses the exact version you have currently installed in your repo. If you don't want to have patch changes then use the npm way of doing it and set the dependency to a fixed version.

[ivanhofer]

@WarningImHack3r after the refactor wil lbe mergen you wil lbe able to call this function to update the module version:

import { updateSdkModuleVersion } from '@inlang/sdk-js/adapter-sveltekit'
updateSdkModuleVersion()