Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Action sometimes fails for mac-os and windows #69

Open
meretp opened this issue Jun 22, 2023 · 3 comments
Open

GH Action sometimes fails for mac-os and windows #69

meretp opened this issue Jun 22, 2023 · 3 comments
Assignees
@meretp

Comments

@meretp
Copy link
Contributor

meretp commented Jun 22, 2023

Sometimes the GH action to run the tests and linter fails due to a problem with the installation of poetry (e.g. here). This seems to only occur for mac-os and windows. But as the GH action uses a matrix all other jobs are cancelled if one fails. As a short fix we should ensure that all tests and the linter are run for ubuntu-latest (at least).
This was referenced Jun 27, 2023
Open
Merged
@meretp
Copy link
Contributor Author

meretp commented Jun 28, 2023

Concurrency might help here: https://docs.github.com/en/actions/using-jobs/using-concurrency

@meretp meretp self-assigned this Jul 6, 2023
meretp added a commit to meretp/opossum.lib.py that referenced this issue Jul 6, 2023
@meretp
[hot-fix] don't cancel matrix jobs if one job fails
df1f9cb 
Disable the fail-fast strategy on matrix elements to ensure that the jobs for ubuntu are run even if the ones for windows or mac fail.

Issue opossum-tool#69

Signed-off-by: Meret Behrens <[email protected]>
@meretp meretp mentioned this issue Jul 6, 2023
Merged
@meretp
Copy link
Contributor Author

meretp commented Sep 5, 2023

seems like the issue is solved for #90 and #91, this ticket should be reopened if the issue reoccurs

@meretp meretp closed this as completed Sep 5, 2023
@meretp
Copy link
Contributor Author

meretp commented Sep 8, 2023

issue reoccured in #92

@meretp meretp reopened this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meretp meretp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meretp