Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interfaces: fix value lookup in LinkAddressField #8161 #8162

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

interfaces: fix value lookup in LinkAddressField #8161 #8162

wants to merge 2 commits into from

Conversation

fichtner
Copy link
Member

@fichtner fichtner commented Dec 23, 2024 •
edited
Loading

As described in #8161 "WAN" is displayed because the default in the XML is "wan". internalValue stays "wan" for the lifetime of the field, which makes me question its use in __toString() and perhaps getValidators(). Thoughts?

@fichtner fichtner self-assigned this Dec 23, 2024
@fichtner fichtner linked an issue Dec 23, 2024 that may be closed by this pull request
GUI value of GRE tunnel config does not match the configured value #8161
Open
2 tasks
@fichtner fichtner mentioned this pull request Dec 23, 2024
Closed
@fichtner fichtner marked this pull request as draft December 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdSchellevis AdSchellevis Awaiting requested review from AdSchellevis

Assignees

@fichtner fichtner

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI value of GRE tunnel config does not match the configured value
2 participants
@fichtner @AdSchellevis