Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 release is missing https://pkg.go.dev/github.com/opiproject/sztp/[email protected] #417

Open
glimchb opened this issue Jun 24, 2024 · 11 comments
Labels
good first issue Good for newcomers

Comments

@glimchb
Copy link
Member

glimchb commented Jun 24, 2024

@glimchb glimchb changed the title v0.2 release is missing v0.2.0 release is missing https://pkg.go.dev/github.com/opiproject/sztp/[email protected] Jun 24, 2024
@glimchb glimchb added the good first issue Good for newcomers label Jun 24, 2024
@glimchb
Copy link
Member Author

glimchb commented Jun 26, 2024

@Xeckt @bhoopesh369 can any of you look into this ?

@Xeckt
Copy link
Contributor

Xeckt commented Jun 26, 2024

Sure, I can take a look, had similar issues myself before.

@Xeckt
Copy link
Contributor

Xeckt commented Jun 26, 2024

Looks like it only detects the versioning for the sztp project instead of sztp-agent, and complains about it missing the package:

~/Documents/GitHub/sztp git:[cli-fixes]
go install github.com/opiproject/sztp/[email protected]
go: downloading github.com/opiproject/sztp v0.2.0
go: github.com/opiproject/sztp/[email protected]: module github.com/opiproject/[email protected] found, but does not contain package github.com/opiproject/sztp/sztp-agent

Which makes sense considering you removed it. Everything will have to be through opiproject/sztp instead which won't work so long as there is no go.mod in the root of the project. Not sure how this should update as you can't version a folder in github...

@bhoopesh369
Copy link
Contributor

bhoopesh369 commented Jun 26, 2024

I think tagging the packages inside will do it?
since I guess only the folder was tagged

@glimchb
Copy link
Member Author

glimchb commented Jun 26, 2024

maybe move everything up 1 level #416 git mv sztp-agent/* . ?

@bhoopesh369
Copy link
Contributor

@bhoopesh369
Copy link
Contributor

maybe move everything up 1 level #416 git mv sztp-agent/* . ?

Would be the ideal solution

@Xeckt
Copy link
Contributor

Xeckt commented Jun 27, 2024

I think tagging the packages inside will do it? since I guess only the folder was tagged

What I was thinking.

@glimchb
Copy link
Member Author

glimchb commented Jun 27, 2024

maybe move everything up 1 level #416 git mv sztp-agent/* . ?

Would be the ideal solution

let's do it. I'm supportive

@Xeckt
Copy link
Contributor

Xeckt commented Jul 5, 2024

We're happy to do this, in this case everything pretty much being located in the root of the project?

@glimchb
Copy link
Member Author

glimchb commented Jul 5, 2024

I was waiting for #427 to go in , to avoid merge conflicts, after we can restructure folders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants