skip image download if same image is running

[glimchb]

the correct flow is:

If the device is running a different image, the device downloads the image, uses the new image to upgrade, and then reboots with the new image.

today in the code the image is always being downloaded

see

sztp/sztp-agent/pkg/secureagent/daemon.go

Line 55 in 2b14bd2

err = a.downloadAndValidateImage()

[h0lyalg0rithm]

@glimchb I will start working on this feature

[glimchb]

assigned to @h0lyalg0rithm

[glimchb]

@h0lyalg0rithm note, this is not just about correct image is already downloaded, but also maybe it is already installed and running as well... also skip that in this case.... we also might introduce a new flag --force or --force-download something like this...

[h0lyalg0rithm]

@glimchb At the moment I think there is no way to know if image is running.
Do you think it makes sense to save the pid of the configuration script run and check if it exists to skip the download. Is this what you were expected

[glimchb]

@glimchb At the moment I think there is no way to know if image is running. Do you think it makes sense to save the pid of the configuration script run and check if it exists to skip the download. Is this what you were expected

@h0lyalg0rithm , the running image version is available via uname -a or cat /etc/os-release , see here :

sztp/sztp-agent/pkg/secureagent/utils.go

Lines 45 to 51 in aa72379

	cfg, err := ini.Load(OS_RELEASE_FILE)
	if err != nil {
	log.Printf("[ERROR] Error loading os-release file: %v", err)
	} else {
	osName = cfg.Section("").Key("NAME").String()
	osVersion = cfg.Section("").Key("VERSION").String()
	}

[h0lyalg0rithm]

@glimchb .The JSONContent field has a stringified version of this information but its not stored anywhere, should it be stored somewhere before and then compared against the bootimage.
How should we compare the os-release image with the boot image?

[glimchb]

@glimchb .The JSONContent field has a stringified version of this information but its not stored anywhere, should it be stored somewhere before and then compared against the bootimage. How should we compare the os-release image with the boot image?

boot image is your ISO image you will eventually run... for example Ubuntu22.04 from https://releases.ubuntu.com/jammy/ubuntu-22.04.4-live-server-amd64.iso

so you download this image, then you install it using post-config script and then you reboot... not you are running this image...
so if now somebody gives me sztp again the same image https://releases.ubuntu.com/jammy/ubuntu-22.04.4-live-server-amd64.iso i know i already run it...

no need to store anything anywhere in my opinion...

[h0lyalg0rithm]

@glimchb Apologize if I am asking similar questions again. But when the machine reboots we would get a new jsonContent information when a new agent is instantiated.

sztp/sztp-agent/pkg/secureagent/agent.go

Line 99 in aa72379

InputJSONContent: generateInputJSONContent(),

How exactly should I do know if its a new image then?