From 61dbf13b3631ce8df753a164a887e54020969baf Mon Sep 17 00:00:00 2001 From: Abhash Solanki Date: Thu, 11 Jul 2024 16:18:03 +0530 Subject: [PATCH] linters fix Signed-off-by: Abhash Solanki --- .github/workflows/ansible.yml | 15 ++++++++------- roles/bmc_fw_update/tasks/main.yml | 7 ++++++- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ansible.yml b/.github/workflows/ansible.yml index 673be37..8b55b17 100644 --- a/.github/workflows/ansible.yml +++ b/.github/workflows/ansible.yml @@ -104,13 +104,14 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.9", "3.10", "3.11"] - ansible-version: [stable-2.17, stable-2.15, stable-2.16] - exclude: - # Ansible-core 2.16 is supported only from Python 3.10 onwards - - python-version: "3.9" - ansible-version: stable-2.16 - + python-version: ["3.9", "3.10", "3.11"] + ansible-version: [stable-2.15, stable-2.16, stable-2.17] + exclude: + # Ansible-core 2.16 and 2.17 are supported only from Python 3.10 onwards + - python-version: "3.9" + ansible-version: stable-2.16 + - python-version: "3.9" + ansible-version: stable-2.17 steps: # Important: This sets up your GITHUB_WORKSPACE environment variable - name: Checkout the source code diff --git a/roles/bmc_fw_update/tasks/main.yml b/roles/bmc_fw_update/tasks/main.yml index efc029b..e590ba2 100644 --- a/roles/bmc_fw_update/tasks/main.yml +++ b/roles/bmc_fw_update/tasks/main.yml @@ -171,6 +171,10 @@ category: Update command: GetUpdateStatus baseuri: "{{ inventory_hostname }}" + username: "{{ dpu_bmc_username | default(omit) }}" + password: "{{ dpu_bmc_password | default(omit) }}" + auth_token: "{{ dpu_bmc_token | default(omit) }}" + update_handle: "{{ bmc_firmware_update_taskid }}" register: update_progress until: update_progress.redfish_facts.update_status.status != 'Running' retries: 60 @@ -208,4 +212,5 @@ msg: "{{ bmc_fw_update_version_failure }}" when: - bmc_fw_update_reboot is true - - not bmc_fw_update_image_file is search(bmc_fw_update_got_fw_version | regex_search('[0-9-.]+')) + - not bmc_fw_update_image_file is search(bmc_fw_update_got_fw_version | regex_search('[0-9-.]+'))" +