From b5e34280dc149ff9a0aa4f91d68d87a44ae288ba Mon Sep 17 00:00:00 2001 From: Mikalai Radchuk Date: Wed, 12 Jun 2024 15:25:29 +0200 Subject: [PATCH] Improve error message for all namespaces Signed-off-by: Mikalai Radchuk --- pkg/convert/registryv1.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/convert/registryv1.go b/pkg/convert/registryv1.go index a4ed09fe..326e0999 100644 --- a/pkg/convert/registryv1.go +++ b/pkg/convert/registryv1.go @@ -148,6 +148,7 @@ func validateTargetNamespaces(supportedInstallModes sets.Set[string], installNam if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeAllNamespaces)) { return nil } + return fmt.Errorf("supported install modes %v do not support targeting all namespaces", sets.List(supportedInstallModes)) case set.Len() == 1 && !set.Has(""): if supportedInstallModes.Has(string(v1alpha1.InstallModeTypeSingleNamespace)) { return nil