New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The GRPC server in opm produces random channel order for FBC catalogs #1069

Open

cdjohnson opened this issue Feb 22, 2023 · 2 comments

Contributor

cdjohnson commented Feb 22, 2023

We have a large catalog. We just converted it from sqlite to fbc:
FBC:
icr.io/cpopen/ibm-operator-catalog:latest

SQLITE:
icr.io/cpopen/ibm-operator-catalog:sqlite-latest

It looks like the order in which the channels are being returned via the GetPackage GRPC API in the FBC catalog is non-deterministic, whereas they appeared either in lexicographical ascending order or registry add <bundle> order (not sure which). This results in various clients to display the channels in a random order, whereas they were being displayed in a seemingly-sorted order before (e.g. the OpenShift Console).

To reproduce:

$ podman run -d --name catalog -p 50051:50051 "icr.io/cpopen/ibm-operator-catalog:latest"
$ grpcurl -plaintext  -d '{"name":"ibm-mq"}' localhost:50051 api.Registry/GetPackage | jq -r .channels[].csvName
ibm-mq.v2.0.8
ibm-mq.v2.1.0
ibm-mq.v1.2.0
ibm-mq.v1.6.0
ibm-mq.v1.7.0
ibm-mq.v1.8.2
ibm-mq.v1.5.0
ibm-mq.v2.2.2
ibm-mq.v2.3.0
ibm-mq.v1.0.0
ibm-mq.v1.1.0
ibm-mq.v1.3.8
ibm-mq.v1.4.0

$ grpcurl -plaintext  -d '{"name":"ibm-mq"}' localhost:50051 api.Registry/GetPackage | jq -r .channels[].csvName
ibm-mq.v1.0.0
ibm-mq.v1.1.0
ibm-mq.v1.3.8
ibm-mq.v1.4.0
ibm-mq.v1.5.0
ibm-mq.v2.2.2
ibm-mq.v2.3.0
ibm-mq.v1.2.0
ibm-mq.v1.6.0
ibm-mq.v1.7.0
ibm-mq.v1.8.2
ibm-mq.v2.0.8
ibm-mq.v2.1.0

vs the sqlite version:

$ podman run -d --name catalog -p 50051:50051 "icr.io/cpopen/ibm-operator-catalog:sqlite-latest"
$ grpcurl -plaintext  -d '{"name":"ibm-mq"}' localhost:50051 api.Registry/GetPackage | jq -r .channels[].csvName
ibm-mq.v1.0.0
ibm-mq.v1.1.0
ibm-mq.v1.2.0
ibm-mq.v1.3.8
ibm-mq.v1.4.0
ibm-mq.v1.5.0
ibm-mq.v1.6.0
ibm-mq.v1.7.0
ibm-mq.v1.8.2
ibm-mq.v2.0.7
ibm-mq.v2.1.0
ibm-mq.v2.2.2

$ grpcurl -plaintext  -d '{"name":"ibm-mq"}' localhost:50051 api.Registry/GetPackage | jq -r .channels[].csvName
ibm-mq.v1.0.0
ibm-mq.v1.1.0
ibm-mq.v1.2.0
ibm-mq.v1.3.8
ibm-mq.v1.4.0
ibm-mq.v1.5.0
ibm-mq.v1.6.0
ibm-mq.v1.7.0
ibm-mq.v1.8.2
ibm-mq.v2.0.7
ibm-mq.v2.1.0
ibm-mq.v2.2.2

The text was updated successfully, but these errors were encountered:

cdjohnson changed the title ~~The GRPC server in opm produces random channel order~~ The GRPC server in opm produces random channel order for FBC catalogs

Member

awgreene commented Feb 22, 2023

Thanks @cdjohnson! We'll take a closer look a this shortly.

Member

joelanford commented Feb 22, 2023

Some context in a slack thread is here: https://kubernetes.slack.com/archives/C0181L6JYQ2/p1677097814470179?thread_ts=1676998367.355039&cid=C0181L6JYQ2

anik120 added a commit to anik120/operator-lifecycle-manager that referenced this issue


          Sort channels in lexicographical order in Packagemanifest

33b6aa9

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

anik120 mentioned this issue

Sort channels in lexicographical order in packagemanifest operator-framework/operator-lifecycle-manager#2925

Merged

11 tasks

anik120 added a commit to anik120/operator-lifecycle-manager that referenced this issue


          Sort channels in lexicographical order in Packagemanifest

f06ebaf

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

perdasilva pushed a commit to anik120/operator-lifecycle-manager that referenced this issue


          Sort channels in lexicographical order in Packagemanifest

ca055ba

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

perdasilva pushed a commit to anik120/operator-lifecycle-manager that referenced this issue


          Sort channels in lexicographical order in Packagemanifest

65e90aa

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

perdasilva pushed a commit to anik120/operator-lifecycle-manager that referenced this issue


          Sort channels in lexicographical order in Packagemanifest

3b1b3f9

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

perdasilva pushed a commit to operator-framework/operator-lifecycle-manager that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

e4b1532

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

d534b17

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

5600ff4

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

69ee76a

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          OCPBUGS-7910: Sort channels in lexicographical order in Packagemanife…

39405cb

…st (#2925)

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

anik120 mentioned this issue

OCPBUGS-7910: Sort channels in lexicographical order in Packagemanifest(#2925) openshift/operator-framework-olm#473

Closed

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          OCPBUGS-7910: Sort channels in lexicographical order in Packagemanife…

fe3dfd9

…st (#2925)

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          OCPBUGS-7910: Sort channels in lexicographical order in Packagemanife…

…st (#2925)

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

f9b0fca

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

5967c27

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

5936b0f

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

916ddf5

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

92f0299

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

anik120 added a commit to anik120/operator-framework-olm that referenced this issue


          OCPBUGS-7910: Sort channels in lexicographical order in Packagemanife…

4d388fa

…st (#2925)

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

anik120 mentioned this issue

OCPBUGS-7910: Sort channels in lexicographical order in Packagemanifestst (#2925) openshift/operator-framework-olm#476

Merged

tmshort pushed a commit to tmshort/operator-framework-olm that referenced this issue


          Sort channels in lexicographical order in Packagemanifest (#2925)

4bc4eb7

See operator-framework/operator-registry#1069
for more details

Signed-off-by: Anik <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: e4b15326c297f610dbf569d771abd62a703b0eb2

grokspawn mentioned this issue

Package sort for deterministic ordering in ListBundles API #1084

Merged

5 tasks

grokspawn mentioned this issue

OCPBUGS-17157: cache/json: use shared buffers for JSON decoding #1140

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment