Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run/verify go-bindata when crds are changed #126

Open
dinhxuanvu opened this issue Jun 3, 2021 · 1 comment
Open

Automatically run/verify go-bindata when crds are changed #126

dinhxuanvu opened this issue Jun 3, 2021 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triaged
Milestone

Comments

@dinhxuanvu
Copy link
Member

Currently, the make manifests to regen go-bindata needs to be run manually and sometimes it is forgotten. This step should be either run automatically or verify and warn people in advance.

@kevinrizza
Copy link
Member

This seems like it should probably be a blocking check against incoming pull requests on this repository.

@kevinrizza kevinrizza added triaged good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Sep 2, 2021
@kevinrizza kevinrizza added this to the backlog milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. triaged
Projects
None yet
Development

No branches or pull requests

2 participants