Skip to content
This repository has been archived by the owner on May 18, 2023. It is now read-only.

PSync: Compute murmurhash using name TLV, not URI. #30

Open
jefft0 opened this issue Feb 5, 2022 · 0 comments
Open

PSync: Compute murmurhash using name TLV, not URI. #30

jefft0 opened this issue Feb 5, 2022 · 0 comments

Comments

@jefft0
Copy link
Contributor

jefft0 commented Feb 5, 2022

As explained in this issue in the original PSync project, when PSync computes a murmurhash on an NDN name, it currently uses the name URI string. But there are multiple ways to display the URI string and it is not guaranteed to be unique. Instead, the TLV encoding should be used.

The original PSync code has been updated in commit named-data/PSync@32ccfc4 . Similar changes should be made to this library where it calls murmurHash3 on an NDN name. As mentioned in the commit, this is a breaking change. The code used by all PSync participants would need to be updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant