Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Capability - Bug and Feature #1094

Closed
NicFragale opened this issue Apr 19, 2023 · 2 comments
Closed

Service Capability - Bug and Feature #1094

NicFragale opened this issue Apr 19, 2023 · 2 comments

Comments

@NicFragale
Copy link

The following is accepted in the NPaaS/MOP and sent and accepted by OpenZITI controls. Subsequently, it seems accepted by the (at least) Swift version of the Ziti Edge Tunnel.

CIDR range services are accepted normally, however, a contiguous IP range seems to be accepted but not interpreted correctly.

The difference is 192.168.1.0/24 results in an interception range for the IPs that span from [192.168.1.0-192.168.1.255] (255 IPs). However, if you do not wish to expose an IP in that range (for instance, [192.168.1.1] which would correspond potentially to the router/firewall of the range) then you might want to use a range in the format [192.168.1.2-192.168.1.255]. The latter is a better method to exclude IPs in a range than calculating CIDR ranges that avoid it.

The BUG in this is that the range format X-Y seems to be accepted. Perhaps this is interpreted as a valid DNS record? The feature in this is that if range format is a capability, it would be highly useful for exclusion.

image

@dovholuknf
Copy link
Member

For example, this is a "valid" configuratoin:

{
  "protocols": [
    "tcp"
  ],
  "addresses": [
    "192.168.1.10-192.168.1.255"
  ],
  "portRanges": [
    {
      "low": 1,
      "high": 1024
    }
  ]
}

plorenz added a commit that referenced this issue Sep 28, 2023
Update for changes to fabric events model
@smilindave26
Copy link
Member

Agree this is irritating, but will not fix. We validate "legal hostname", and this is a legal hostname. We auto-exclude OS/Ziti needed routes already. We have a separate issue to support explicit exclusion routes (see openziti/ziti-tunnel-sdk-c#855)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants