Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting unnecessary African Story book files from Dev Library #725

Closed
RavanJAltaie opened this issue Oct 6, 2023 · 8 comments
Closed
Assignees
Labels
Remove Asking for the removal of zim files from the download library

Comments

@RavanJAltaie RavanJAltaie added the Remove Asking for the removal of zim files from the download library label Oct 6, 2023
@benoit74 benoit74 self-assigned this Oct 6, 2023
@benoit74
Copy link
Contributor

benoit74 commented Oct 6, 2023

@rgaudin I will need your help on this one.
I think that I need to know how to do it so that I can do it on my own.
Let's discuss about it next week.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 7, 2023

@benoit74 @rgaudin AFAIK, the deletion of these files is done via a service account using SSH.

Could we setup the infra and the documentation to:

  • Have personal accounts
  • To access download.kiwix.org download.openzim.org (or part of them, depending of roles)
  • Share these accounts when necessary
  • log properly actions using this tool

So people in charge don't depend of @rgaudin ?

@rgaudin
Copy link
Member

rgaudin commented Oct 7, 2023

@benoit74 has access ; it's just that he didn't know where the hidden zims where because those are not part of the regular download tree. This has been covered yesterday when this ticket was created.

What you describe seems unnecessary at this stage (because it requires finding and setting up a new service). current process works fine and the requests are low.
We discussed with @benoit74 reviving rules for obsolescence of dev files (that you discarded) because those should be numerous, as per the zim creation process.

@kelson42
Copy link
Collaborator

kelson42 commented Oct 7, 2023

@rgaudin Considering the amount of tickets and comments (including from me) requesting changes at filesystem level, I pretty much disagree that a proper process (following minimal requirements like given by me) is overkill.

@rgaudin
Copy link
Member

rgaudin commented Oct 7, 2023

Creating tickets for deletion requests IS the process and those have all been handled smoothly AFAIK.

I am all for having a proper tool that does what you describe but I regard it as low priority given it requires an effort and it's already working.

Open a separate ticket then (in k8s)

@kelson42
Copy link
Collaborator

kelson42 commented Oct 7, 2023

Open a separate ticket then (in k8s)

I suspect I will simply put the ticket openzim/cms#82 in emphasis for the next CMS milestone.

@rgaudin
Copy link
Member

rgaudin commented Oct 7, 2023

Indeed, makes more sense

@benoit74
Copy link
Contributor

benoit74 commented Oct 9, 2023

All requested files have been deleted, changes will be reflected in dev library UI in more or less 10 minutes.

@benoit74 benoit74 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Remove Asking for the removal of zim files from the download library
Projects
None yet
Development

No branches or pull requests

4 participants