Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to https://nodejs.org/api/n-api.html #31

Closed
kelson42 opened this issue Feb 29, 2020 · 2 comments
Closed

Move to https://nodejs.org/api/n-api.html #31

kelson42 opened this issue Feb 29, 2020 · 2 comments
Assignees
@kelvinhammond
Labels
enhancement

Comments

@kelson42
Copy link
Contributor

nbind is not supported and N-API seems mature/good enough
@kelson42 kelson42 mentioned this issue Feb 29, 2020
Closed
@kelson42 kelson42 pinned this issue Mar 2, 2020
@kelvinhammond
Copy link
Collaborator

@kelson42 is this still an issue?

@kelson42 kelson42 unpinned this issue Apr 30, 2020
@kelson42
Copy link
Contributor Author

@kelvinhammond Thank you very much again for this really important fix. @midik is currently working on a release of it which should be used in next MWoffliner minor release (in the next days). I have as well open a ticket to rearchitecture that binding in a way which is more respectful of libzim design, see #36.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelvinhammond kelvinhammond

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kelson42 @kelvinhammond