-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto deleting books #71
Comments
@rgaudin The CMS should delete the books, whatever for which reasons. We should not have any other logic, anywhere else about book deletion IMO. |
Agrees but:
|
In the meantime, we should probably keep continuing to delete books like we do today. On the CMS side, I'm anyway in favour of having a periodic check if ZIM files are still online. If the file is in a library but not available anymore, then it should trigger an alarm, otherwise I guess it could be removed from the DB silently.
The current logic is appropriate IMO for the moment, I would keep it. Otherwise, we could maybe trigger a deletion in N days, each time a ZIM file leaves the library. Probably we will have to hardcode a few deprecation approaches and make them available to choose at the "title" level. See also #7 for ondemand deletions. |
OK 👍 |
Turning this into an actionable task for M2, we only want to remove the N previous versions of the book, when we receive and record a new one. That number would be a constant and we could start with |
Books are created via a Zimfarm call.
At that moment, ZIMs are probably online or about to be.
We add them to the Title (or create it if it's the first) and that's it.
Over time, we end end with many books for a Title.
We know that we are currently keeping at most 2 dates ZIM files per content on the server so if we have 3 books for a Title in the DB, chances are one of them is not reachable.
We should write down two things IMO:
The text was updated successfully, but these errors were encountered: