Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O_DIRECT implementation misses statx(STATX_DIOALIGN) extension #16970

Open
amotin opened this issue Jan 21, 2025 · 1 comment · May be fixed by #16972
Open

O_DIRECT implementation misses statx(STATX_DIOALIGN) extension #16970

amotin opened this issue Jan 21, 2025 · 1 comment · May be fixed by #16972
Labels
Type: Feature Feature request or new feature

Comments

@amotin
Copy link
Member

amotin commented Jan 21, 2025

To properly use O_DIRECT, applications need to know file system requirements for I/O and buffer alignments. As was mentioned in #16953 (comment), STATX_DIOALIGN extension to statx() (https://man7.org/linux/man-pages/man2/statx.2.html) seems to be the way to do it on Linux since kernel 6.1. Unfortunately it seems zpl_getattr_impl() code around here

zfs/module/os/linux/zfs/zpl_inode.c

Line 486 in 919bc4d

#ifdef STATX_BTIME
does not implement it, while it seems to be an easy change.
@amotin amotin added the Type: Feature Feature request or new feature label Jan 21, 2025
@robn
Copy link
Member

robn commented Jan 21, 2025

I've actually been working on it this week. Hoping to post the PR today.

@robn robn linked a pull request Jan 22, 2025 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Feature request or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement statx(STATX_DIOALIGN) so applications can discover correct O_DIRECT alignment robn/zfs
2 participants
@robn @amotin