Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI #56

Closed
casperdcl opened this issue Sep 25, 2019 · 12 comments · Fixed by #57
Closed

add CI #56

casperdcl opened this issue Sep 25, 2019 · 12 comments · Fixed by #57

Comments

@casperdcl
Copy link
Member

add continuous integration testing.

Presumably currently the site is built automatically by readthedocs.org (without build status feedback on GitHub). Adding our own CI tests means:

  • can easily get build status feedback (e.g. on PRs) before merging
  • can use said CI later to also automate crawling as per automate subproject metadata parsing #55
  • could potentially publish the site directly from CI from an env which we fully control
@casperdcl
Copy link
Member Author

casperdcl commented Sep 25, 2019

@cheelee as discussed please add push access to this repo for machine user @openworm-bot

@casperdcl casperdcl assigned casperdcl and unassigned casperdcl Sep 25, 2019
@cheelee
Copy link

cheelee commented Sep 25, 2019

Done. Does it work?

@casperdcl
Copy link
Member Author

yes but I think as per https://help.github.com/en/articles/repository-permission-levels-for-an-organization#repository-access-for-each-permission-level I think it'll need admin access to this repo to modify webhooks. Hopefully the list of permissions doesn't look to scary to you (esp if you can just enable it only for this repo)

@cheelee
Copy link

cheelee commented Sep 25, 2019

Ok I've set it to the highest level of permissions for the repo - Maintain.

@casperdcl
Copy link
Member Author

casperdcl commented Sep 25, 2019

hmm interesting - can't it be changed to admin? The circleci.com list of repos I can enable CI on using the bot account is currently empty

@cheelee
Copy link

cheelee commented Sep 25, 2019

Maybe I do not have those permissions. @slarson - are you able to assign admin permissions to bot accounts specific to just this repo?

@casperdcl - are you aware of what specific capabilities the account must have to perform its tasks? When I set it to Maintain, it indicated the account would have the permission to push and change repo settings.

@cheelee
Copy link

cheelee commented Sep 25, 2019

Ok nevermind, for some reason I didn't see there was another entry below Maintain earlier. I have set it to Admin for the repo now.

@casperdcl
Copy link
Member Author

kewl yes unfortunately as per the table on https://help.github.com/en/articles/repository-permission-levels-for-an-organization#repository-access-for-each-permission-level it has to be admin for webhooks :/

@cheelee
Copy link

cheelee commented Sep 25, 2019

Ok wait. I am a little confused now. Does that mean @openworm-bot will need to be added to the organization as a member?

@balicea
Copy link
Contributor

balicea commented Sep 25, 2019

@casperdcl I am trying to solve the problem you had earlier with providing admin privileges for webhooks. I am unsure of what the solution is other than adding @openworm-bot as a collaborator for a specific repository with Admin privileges. It seems as each repo has its own webhooks.

@casperdcl
Copy link
Member Author

casperdcl commented Sep 25, 2019

@balicea yes that's right.

I'd think org member with as little privileges as possible, plus admin on the docs repo.

Could just do admin collaborator if you prefer.

Also let me know how you'd like me to send you guys the login details for the bot.

@casperdcl
Copy link
Member Author

managed to set up the webhook and even made a quick configuration (#57)

This was referenced Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants