Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/486 #333

Merged
merged 9 commits into from
Sep 22, 2020
Merged

Feature/486 #333

merged 9 commits into from
Sep 22, 2020

Conversation

jrmartin
Copy link
Contributor

@jrmartin jrmartin commented Aug 28, 2020 •
edited by filippomc
Loading

Closes #334

@jrmartin jrmartin requested a review from filippomc September 4, 2020 15:56
@jrmartin
Copy link
Contributor Author

jrmartin commented Sep 4, 2020

@filippomc These changes were done to accommodate this issue in VFB VirtualFlyBrain/geppetto-vfb#486

The changes in MenuSection.js were done having this kind of configuration in mind, where the caret is not shown by request.
image

filippomc
filippomc requested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suggesting some changes to improve the documentation and make the new feature(s) compliant with other applications.

Also, a proper issue on the Geppetto repo should be created with the scope of the changes. We need to track a roadmap for the Geppetto client which should be independent from osb and any other application.

geppetto-ui/src/list-viewer/ListViewer.js Show resolved Hide resolved
geppetto-ui/src/menu/MenuSection.js Outdated Show resolved Hide resolved
geppetto-ui/src/menu/MenuSection.js Outdated Show resolved Hide resolved
@jrmartin
Copy link
Contributor Author

jrmartin commented Sep 9, 2020

@filippomc Changes done after review, I opened an issue to match this PR issue #334 ( kept this PR opened , let me know if you want me to open a new branch feature/334 instead with a new PR)

@filippomc filippomc linked an issue Sep 22, 2020 that may be closed by this pull request
Expand ListViewer and MenuSection properties #334
Open
filippomc
filippomc approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@filippomc filippomc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@jrmartin jrmartin mentioned this pull request Sep 22, 2020
Merged
@tarelli tarelli merged commit 6dd04a0 into development Sep 22, 2020
@filippomc filippomc mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippomc filippomc filippomc approved these changes

Assignees

@jrmartin jrmartin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand ListViewer and MenuSection properties
3 participants
@jrmartin @filippomc @tarelli