Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Griddle to the latest version compatible with the react version used in the Geppetto codebase #21

Open
ddelpiano opened this issue Jun 7, 2019 · 6 comments
Assignees
Labels
documentation enhancement New feature or request

Comments

@ddelpiano
Copy link
Contributor

ddelpiano commented Jun 7, 2019

  • as per title, update Griddle to the latest compatible with the react version used in the geppetto-client codebase.
  • Test ControlPanel component to ensure that the functionalities are preserved.
  • Test QueryBuilder component to ensure that the functionalities are preserved.
  • Test AdminPanel component to ensure that the functionalities are preserved.
  • Document the major changes have been done to switch from the old to the new version of Griddle in order to semplify the same operation for all the other applications that are using our Griddle fork (OSB, VFB and others).
@ddelpiano ddelpiano added documentation enhancement New feature or request labels Jun 7, 2019
@tarelli tarelli added this to the Release 1.0.1 milestone Jun 12, 2019
@tarelli
Copy link
Member

tarelli commented Jun 26, 2019

@ddelpiano after talking yesterday with @filippomc I'm wondering if this should happen by virtue of having all those components start using the listviewer Filippo is developing which will already be on the latest Griddle (which btw supports infinite scrolling), thoughts?

@jrmartin
Copy link
Contributor

@filippomc Hey Filippo. I saw you updated griddle-react to version 1.13.1 as part of PR #48 . I'm also updating the dependency to the same version as part of this card, I already did but the casper tests are failing due to controlpanel.js still needing changes to make it work with griddle 1.13.1 https://travis-ci.org/openworm/geppetto-application/builds/556094254. Question, are you planning on making changes to controlpanel.js to make it compatible with griddle-react version 1.13.1 as part of PR #48 ? I'm working on the same, don't want to step in your toes if you are already taking care of the same issue.

@filippomc
Copy link
Contributor

filippomc commented Jul 11, 2019

Hi @jrmartin I wouldn't waste time on the actual controlpanel only to update griddle: the api changed really much from 0.x to 1.x. There is also a plan to make a new control panel (see also #26) which will start from the new ListViewer coming from #41 .

@jrmartin
Copy link
Contributor

@filippomc Alright, good to know . 👍

@tarelli
Copy link
Member

tarelli commented Aug 13, 2019

We'll need to port the fixes to the new infinite scrolling plugin before we can do what @filippomc is proposing.

@tarelli
Copy link
Member

tarelli commented Aug 13, 2019

@gidili knows what the fixes need to be

@filippomc filippomc removed this from the Release 1.0.1 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants