Components spring cleaning

[tarelli]

• Do an inventory of all components inside controls, widgets, interface. The goal is we need to qualify whether to remove or not each of the components which depends on code quality, usage and usefulness. The question we want to answer is: if we were to build a new geppetto application today is this a component that we would use or not? Track their usage (check geppetto-vfb, geppetto-osb, geppetto-application, geppetto-hm, geppetto-netpyne, geppetto-nwbexplorer), check last commit, check code quality (ES6? Full react? is jQuery used? is it used by the ComponentFactory?). For instance, we probably want to remove all controls since nowadays we can just rely on an external library to do the job, e.g. Material UI
• Review the inventory, agree what we are going to remove.
• Remove the components
• Create a card to document all components that we have not removed on org.geppetto.docs
• Create a card to create a showcase for the components that we have not removed (e.g. https://github.com/openworm/geppetto-client/blob/development/js/components/interface/listViewer/showcase/ListViewerShowcase.js)

[afonsobspinto]

An initial spreadsheet can be found here (generated with https://github.com/afonsobspinto/GeppettoClientStats)

Next steps:

• Evaluate effectiveness of the script (by manually go through (some of) the values generated and evaluate them -> new column 'reviewed' will be added)
• Signal relevant components

Questions:

1. Definition of full-react
2. Definition of relevant components (which stats would made a component be signalled as to be removed?)

[afonsobspinto]

A new spreadsheet was generated with:

• New columns: Type, Usage, G., Geppetto.
• Fix usage: Now it as in consideration G.addWidget and GEPPETTO.ComponentFactory.addComponent
• Add new repos: geppetto-client, geppetto-hnn
• Use new branchs: (VirtualFlyBrain/geppetto-vfb, development)

In parallel a sonarqube report was generated. You can find it here

Proposal next steps:

• Join information of sonarqube to spreedsheet
• Signal relevant components

Questions:

1. Presence of false-positives like: https://github.com/openworm/geppetto-client/blob/master/js/components/interface/3dCanvas/SceneController.js#L100

[afonsobspinto]

A new spreadsheet was generated with:

• New columns: Applications Usage

• Fix usage: Now it as in consideration relative path imports/requires (needs to contain component name and last folder from filepath - necessary to distinguish between https://github.com/openworm/geppetto-client/blob/master/js/components/controls/mixins/Button.js and https://github.com/openworm/geppetto-client/blob/master/js/components/controls/button/Button.js for example)

[filippomc]

Closing as merged into #174