Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write lua tests #7

Closed
nemesifier opened this issue May 1, 2020 · 4 comments · Fixed by #26
Closed

Write lua tests #7

nemesifier opened this issue May 1, 2020 · 4 comments · Fixed by #26
Assignees
@devkapilbansal
Labels
enhancement New feature or request hacktoberfest Easy issues for attracting Hacktoberfest participants.

Comments

@nemesifier
Copy link
Member

We need to write tests for the lua functions.

I hope we can use mocking to simulate the calls to the network programs we use to get the data (ubus, arp, etc).
@nemesifier nemesifier added the enhancement New feature or request label May 12, 2020
@nemesifier nemesifier added the hacktoberfest Easy issues for attracting Hacktoberfest participants. label Oct 3, 2020
@devkapilbansal
Copy link
Member

I would like to work on this

@devkapilbansal devkapilbansal self-assigned this Mar 15, 2021
@devkapilbansal devkapilbansal removed their assignment Mar 24, 2021
@devkapilbansal
Copy link
Member

I need some more time, understand the scripts. Till then, if anyone is interested they can work on this issue

@devkapilbansal devkapilbansal self-assigned this Apr 5, 2021
@devkapilbansal devkapilbansal mentioned this issue May 18, 2021
Merged
@nemesifier
Copy link
Member Author

Closed by #26.

@devkapilbansal
Copy link
Member

Issue already solved in 91f319a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devkapilbansal devkapilbansal

Labels
enhancement New feature or request hacktoberfest Easy issues for attracting Hacktoberfest participants.
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[test] Lua tests for netjson monitoring devkapilbansal/openwrt-openwisp-monitoring
2 participants
@nemesifier @devkapilbansal