[bug] Passing multiple options to OpenWrt sysupgrade ineffective

[nemesifier]

I tried passing both options -F and -n.

The webUI says it has executed it but the image kept being getting rejected by OpenWrt, even though I used -F.

I executed the command manually (sysupgrade -F -n -v)and sysupgrade executed successfully.

I suspect passing multiple options right now is not working.

[pandafy]

@nemesifier I tried to replicate the error locally but couldn't. This is the output of celery worker

[2025-02-05 12:29:10,014: INFO/ForkPoolWorker-1] # Connection successful, starting upgrade...
[2025-02-05 12:29:11,092: INFO/ForkPoolWorker-1] Executing command: test -f /etc/openwisp/firmware_checksum
[2025-02-05 12:29:11,096: INFO/ForkPoolWorker-1] # Image checksum file not found, proceeding with the upload of the new image...
[2025-02-05 12:29:11,115: INFO/ForkPoolWorker-1] Executing command: rm -rf /tmp/opkg-lists/
[2025-02-05 12:29:11,142: INFO/ForkPoolWorker-1] Executing command: sync && echo 3 > /proc/sys/vm/drop_caches
[2025-02-05 12:29:11,210: INFO/ForkPoolWorker-1] Executing command: cat /proc/meminfo | grep MemAvailable
[2025-02-05 12:29:11,268: INFO/ForkPoolWorker-1] MemAvailable:     449992 kB

[2025-02-05 12:29:20,293: INFO/ForkPoolWorker-1] Executing command: /sbin/sysupgrade --test /tmp/openwrt-x86-64-combined-ext4.img
[2025-02-05 12:29:21,131: INFO/ForkPoolWorker-1] # Sysupgrade test passed successfully, proceeding with the upgrade operation...
[2025-02-05 12:29:21,143: INFO/ForkPoolWorker-1] # Upgrade operation in progress...
[2025-02-05 12:29:21,172: INFO/Process-1:1] Connected (version 2.0, client dropbear)
[2025-02-05 12:29:21,276: INFO/Process-1:1] Authentication (publickey) failed.
[2025-02-05 12:29:21,297: INFO/Process-1:1] Authentication (publickey) failed.
[2025-02-05 12:29:21,303: INFO/Process-1:1] Authentication (publickey) failed.
[2025-02-05 12:29:21,876: INFO/Process-1:1] Authentication (publickey) failed.
[2025-02-05 12:29:21,879: INFO/Process-1:1] Authentication (password) successful!
[2025-02-05 12:29:21,911: WARNING/Process-1:1] /sbin/sysupgrade -v -n -F /tmp/openwrt-x86-64-combined-ext4.img
[2025-02-05 12:29:21,911: INFO/Process-1:1] Executing command: rm /etc/openwisp/checksum 2> /dev/null
[2025-02-05 12:29:21,922: INFO/Process-1:1] Executing command: /sbin/sysupgrade -v -n -F /tmp/openwrt-x86-64-combined-ext4.img
[2025-02-05 12:29:23,584: INFO/Process-1:1] Commencing upgrade. Closing all shell sessions.

[2025-02-05 12:29:23,584: INFO/Process-1:1] # Commencing upgrade. Closing all shell sessions.
Image metadata not found
Reading partition table from bootdisk...
Reading partition table from image...
Partition layout has changed. Full image will be written.

[2025-02-05 12:29:23,608: INFO/ForkPoolWorker-1] # SSH connection closed, will wait 150 seconds before attempting to reconnect...