Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AnswerFormatHelp.pl #1043

Open
Alex-Jordan opened this issue Mar 25, 2024 · 5 comments
Open

Updating AnswerFormatHelp.pl #1043

Alex-Jordan opened this issue Mar 25, 2024 · 5 comments

Comments

@Alex-Jordan
Copy link
Contributor

AnswerFormatHelp.pl is a macro library in the OPL, For Lewis folder, referenced over 17000 by files in the OPL. It has a few issues:

  • It doesn't work for problems rendered through iframes in the way that PTX renders problems.
  • It has some outdated information about PG syntax.

Should pg take over this file and update it? With consultation/collaboration/approval from @paultpearson ?

@drgrice1
Copy link
Member

PG has already taken over this file. It is in the macros/deprecated directory. It has already been updated. The AnswerFormatHelp method just calls helpLink from PGbasicmacros.pl.

@Alex-Jordan
Copy link
Contributor Author

Ah, OK. Well it seems there is more to be done based on some reporting from today. But if it's been updated like you describe, then probably the issues are all for me to work on in the PTX repository, in pretext-webwork.js. I'll check on that and close this when I confirm.

@drgrice1
Copy link
Member

If there is, then it is the helpLink method that needs work. Note that still uses knowlLink, and I don't know of any real way to fix that. You can't use an accordion like we now do for solutions and hints.

@paultpearson
Copy link
Member

paultpearson commented Mar 25, 2024 via email

@Alex-Jordan
Copy link
Contributor Author

For static PTX rendering, I just need to adjust things so that the URL in the output is not a relative path. It should be doable to prepend the WW server's domain.

I haven't had time to look into the following, but when a live problem is in an iframe in a PTX project, and the user clicks the help link, the iframe reloads in a strange way, loading the ambient page in the iframe. It could be a bug in PTX's pretext-webwork.js that I just need to make time to investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants