Skip to content

Commit 0aba6d1

Browse files
committed
cleanup from PR#1216 review
1 parent 130bfc5 commit 0aba6d1

File tree

1 file changed

+7
-19
lines changed

1 file changed

+7
-19
lines changed

lib/Value/Matrix.pm

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -418,9 +418,7 @@ sub isOne {
418418
}
419419
} else {
420420
for my $row (@{ $self->{data} }) {
421-
if (!$row->isOne) {
422-
return 0;
423-
}
421+
return 0 unless $row->isOne;
424422
}
425423
}
426424
return 1;
@@ -470,9 +468,7 @@ sub isUpperTriangular {
470468
}
471469
} else {
472470
for my $row (@{ $self->{data} }) {
473-
if (!$row->isUpperTriangular) {
474-
return 0;
475-
}
471+
return 0 unless $row->isUpperTriangular;
476472
}
477473
}
478474
return 1;
@@ -499,9 +495,7 @@ sub isLowerTriangular {
499495
}
500496
} else {
501497
for my $row (@{ $self->{data} }) {
502-
if (!$row->isLowerTriangular) {
503-
return 0;
504-
}
498+
return 0 unless $row->isLowerTriangular;
505499
}
506500
}
507501
return 1;
@@ -537,9 +531,7 @@ sub isSymmetric {
537531
}
538532
} else {
539533
for my $row (@{ $self->{data} }) {
540-
if (!$row->isSymmetric) {
541-
return 0;
542-
}
534+
return 0 unless $row->isSymmetric;
543535
}
544536
}
545537
return 1;
@@ -588,15 +580,13 @@ sub isREF {
588580
}
589581
} else {
590582
for my $row (@{ $self->{data} }) {
591-
if (!$row->isREF) {
592-
return 0;
593-
}
583+
return 0 unless $row->isREF;
594584
}
595585
}
596586
return 1;
597587
}
598588

599-
=head3 C<isREF>
589+
=head3 C<isRREF>
600590
601591
Check if a Matrix is in reduced row echelon form (for degree > 2, applies to frontal slice matrices)
602592
@@ -631,9 +621,7 @@ sub isRREF {
631621
}
632622
} else {
633623
for my $row (@{ $self->{data} }) {
634-
if (!$row->isRREF) {
635-
return 0;
636-
}
624+
return 0 unless $row->isREF;
637625
}
638626
}
639627
return 1;

0 commit comments

Comments
 (0)