diff --git a/src/MSCHAPv2_bs_fmt_plug.c b/src/MSCHAPv2_bs_fmt_plug.c index 7a289f211e..3494b16f8e 100644 --- a/src/MSCHAPv2_bs_fmt_plug.c +++ b/src/MSCHAPv2_bs_fmt_plug.c @@ -281,13 +281,11 @@ static char *prepare(char *split_fields[10], struct fmt_main *pFmt) } } } - else if (split_fields[0] && split_fields[3] && split_fields[4] && split_fields[5] && - strlen(split_fields[3]) == CHALLENGE_LENGTH/2 && + else if (strlen(split_fields[3]) == CHALLENGE_LENGTH/2 && strlen(split_fields[4]) == CIPHERTEXT_LENGTH && strlen(split_fields[5]) == CHALLENGE_LENGTH/2) ret = prepare_long(split_fields); - else if (split_fields[0] && split_fields[3] && split_fields[4] && - strlen(split_fields[3]) == CHALLENGE_LENGTH/4 && + else if (strlen(split_fields[3]) == CHALLENGE_LENGTH/4 && strlen(split_fields[4]) == CIPHERTEXT_LENGTH) ret = prepare_short(split_fields); else diff --git a/src/NETLMv2_fmt_plug.c b/src/NETLMv2_fmt_plug.c index a0fd44f875..e04981d004 100644 --- a/src/NETLMv2_fmt_plug.c +++ b/src/NETLMv2_fmt_plug.c @@ -183,7 +183,9 @@ static char *prepare(char *split_fields[10], struct fmt_main *self) if (!strncmp(split_fields[1], FORMAT_TAG, FORMAT_TAG_LEN)) return split_fields[1]; - if (!login || !uid || !srv_challenge || !nethashv2 || !cli_challenge) + if (!login[0] || !strcmp(login, "?")) + return split_fields[1]; + if (!srv_challenge[0] || !nethashv2[0] || !cli_challenge[0]) return split_fields[1]; /* DOMAIN\USER: -or- USER::DOMAIN: */ diff --git a/src/NETNTLMv2_fmt_plug.c b/src/NETNTLMv2_fmt_plug.c index 43da16da8c..ba0753cde2 100644 --- a/src/NETNTLMv2_fmt_plug.c +++ b/src/NETNTLMv2_fmt_plug.c @@ -197,7 +197,9 @@ static char *prepare(char *split_fields[10], struct fmt_main *self) if (!strncmp(split_fields[1], FORMAT_TAG, FORMAT_TAG_LEN)) return split_fields[1]; - if (!login || !uid || !srv_challenge || !nethashv2 || !cli_challenge) + if (!login[0] || !strcmp(login, "?")) + return split_fields[1]; + if (!srv_challenge[0] || !nethashv2[0] || !cli_challenge[0]) return split_fields[1]; /* DOMAIN\USER: -or- USER::DOMAIN: */ diff --git a/src/asaMD5_fmt_plug.c b/src/asaMD5_fmt_plug.c index 8294ee9c59..b35948fff8 100644 --- a/src/asaMD5_fmt_plug.c +++ b/src/asaMD5_fmt_plug.c @@ -103,7 +103,7 @@ static char *prepare(char *split_fields[10], struct fmt_main *self) return split_fields[1]; if (!valid(split_fields[1], self)) { - if (split_fields[1] && strlen(split_fields[1]) == 16) { + if (strlen(split_fields[1]) == 16) { char username[4+1] = ""; strncat(username, split_fields[0], 4); diff --git a/src/dynamic_fmt.c b/src/dynamic_fmt.c index 87a65f0ad5..be1303b53d 100644 --- a/src/dynamic_fmt.c +++ b/src/dynamic_fmt.c @@ -1138,7 +1138,7 @@ static char *prepare(char *split_fields[10], struct fmt_main *pFmt) // at this point max length is still < 512. 491 + strlen($dynamic_xxxxx$) is 506 if (pPriv->nUserName && !strstr(cpBuilding, "$$U")) { - if (split_fields[0] && split_fields[0][0] && strcmp(split_fields[0], "?")) { + if (split_fields[0][0] && strcmp(split_fields[0], "?")) { char *userName=split_fields[0], *cp; static char ct[1024]; // assume field[0] is in format: username OR DOMAIN\\username If we find a \\, then use the username 'following' it. @@ -1154,7 +1154,7 @@ static char *prepare(char *split_fields[10], struct fmt_main *pFmt) for (i = 0; i < 10; ++i) { if (pPriv->FldMask&(MGF_FLDx_BIT<