Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MD5_std.c should use HH2() also in its 2x interleaved code #5635

Open
solardiz opened this issue Dec 23, 2024 · 0 comments · May be fixed by #5636
Open

MD5_std.c should use HH2() also in its 2x interleaved code #5635

solardiz opened this issue Dec 23, 2024 · 0 comments · May be fixed by #5636

Comments

@solardiz
Copy link
Member

@magnumripper's commit a649032 introduced "common subexpressions in round 3" optimizations into many of our source files implementing (pieces of) MD4 and MD5. However, in MD5_std.c it did so only for the non-interleaved version of the code and missed the interleaved version. We could want to extend this optimization to that version as well.

This is our legacy scalar code, which rarely matters these days. But it does still have some uses.

@solardiz solardiz added this to the Potentially 2.0.0 milestone Dec 23, 2024
magnumripper added a commit to magnumripper/john that referenced this issue Dec 23, 2024
magnumripper added a commit to magnumripper/john that referenced this issue Dec 23, 2024
magnumripper added a commit to magnumripper/john that referenced this issue Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant