Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Fix coverity scan issues in Node class #28268

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[CPU] Fix coverity scan issues in Node class #28268

merged 2 commits into from
Jan 9, 2025

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Jan 3, 2025 •
edited by EgorDuplensky
Loading

Details:

  • Fix performance inefficiencies coverity remarks in Node class implementation of CPU plugin: 1563144, 1563146

Tickets:

  • 153687

@aobolensk aobolensk requested review from a team as code owners January 3, 2025 15:21
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 3, 2025
@aobolensk aobolensk force-pushed the cov-1563144-1563146 branch from 0ecdfde to 8c056d5 Compare January 7, 2025 09:17
EgorDuplensky
EgorDuplensky reviewed Jan 7, 2025
View reviewed changes
src/plugins/intel_cpu/src/node.cpp Outdated
@@ -383,7 +383,7 @@ void Node::selectPreferPrimitiveDescriptorWithShape(const std::vector<impl_desc_

const bool isCompatible = curDesc->isCompatible(*parentDesc);
if (!isCompatible) {
if (!isReorderRequired(parentDesc, curDesc)) {
if (!isReorderRequired(std::move(parentDesc), curDesc)) {
Copy link
Contributor

@EgorDuplensky EgorDuplensky Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead change the semantics of isReorderRequired to:

bool Node::isReorderRequired(const MemoryDescCPtr& desc1, const MemoryDescCPtr& desc2) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@aobolensk aobolensk force-pushed the cov-1563144-1563146 branch from 8c056d5 to aa3c8b8 Compare January 7, 2025 16:13
@EgorDuplensky EgorDuplensky changed the title Fix coverity scan issues in Node class of CPU plugin: 1563144, 1563146 Fix coverity scan issues in Node class of CPU plugin Jan 9, 2025
@EgorDuplensky EgorDuplensky changed the title Fix coverity scan issues in Node class of CPU plugin [CPU] Fix coverity scan issues in Node class Jan 9, 2025
@EgorDuplensky
Copy link
Contributor

@dmitry-gorokhov Ready for merge

@dmitry-gorokhov dmitry-gorokhov added this pull request to the merge queue Jan 9, 2025
Merged via the queue into openvinotoolkit:master with commit 8a6bac6 Jan 9, 2025
181 checks passed
MirceaDan99 pushed a commit to MirceaDan99/openvino that referenced this pull request Jan 22, 2025
@aobolensk @MirceaDan99
[CPU] Fix coverity scan issues in Node class (openvinotoolkit#28268)
5602fcd 
### Details:
- Fix performance inefficiencies coverity remarks in Node class
implementation of CPU plugin: 1563144, 1563146

### Tickets:
 - 153687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aobolensk @EgorDuplensky @dmitry-gorokhov