Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Operation list to be supported #28584

Open
mvafin opened this issue Jan 21, 2025 · 17 comments
Open

[Good First Issue]: Operation list to be supported #28584

mvafin opened this issue Jan 21, 2025 · 17 comments
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Jan 21, 2025

Hello, everyone. I noticed an interest in PyTorch GFI. Right now we have the following list of operations that can be enabled:

If you want to enable one or more of these operations, please comment with short description of how you plan to enable it and what OpenVINO operations would you use and I will create GFI for you.

Please note that not all operations can be easily enabled.

aten::__contains__
aten::__is__
aten::__isnot__
aten::__lshift__
aten::__rshift__
aten::_autocast_to_full_precision
aten::_autocast_to_reduced_precision
aten::_fake_quantize_learnable_per_channel_affine
aten::_fake_quantize_learnable_per_tensor_affine
aten::_nested_tensor_from_mask
aten::_sparse_mm
aten::_standard_gamma
aten::_to_copy
aten::_transformer_encoder_layer_fwd
aten::affine_grid_generator
aten::angle
aten::bernoulli_
aten::binary_cross_entropy_with_logits
aten::bincount
aten::bitwise_right_shift
aten::clear
aten::constant_pad_nd
aten::cross_entropy_loss
aten::Delete
aten::dict
aten::dot
aten::embedding_renorm_
aten::extend
aten::fft_fft
aten::fft_ifft
aten::fft_irfft2
aten::fft_rfft
aten::fft_rfft2
aten::find
aten::format
aten::fractional_max_pool2d
aten::get
aten::grad
aten::histc
aten::hstack
aten::isin
aten::items
aten::kthvalue
aten::linalg_det
aten::linalg_multi_dot
aten::logit
aten::lstm_cell
aten::max_unpool2d
aten::mT
aten::nan_to_num
aten::pad_sequence
aten::percentFormat
aten::poisson
aten::polar
aten::pop
aten::quantized_lstm
aten::rad2deg
aten::randperm
aten::ravel
aten::replace
aten::reverse
aten::rms_norm
aten::set_
aten::smooth_l1_loss
aten::special_logit
aten::stack
aten::str
aten::take
aten::tensordot
aten::to_dense
aten::to_mkldnn
aten::to_padded_tensor
aten::uniform_
aten::unique_consecutive
aten::values
aten::vstack
prim::CallFunction
prim::CallMethod
prim::ConstantMKLDNNTensor
prim::data
prim::dtype
prim::is_nested
prim::isinstance
prim::layout
prim::mkldnn_convolution
prim::tolist
prim::unchecked_cast
prim::Uninitialized
quantized::batch_norm2d
quantized::conv1d
quantized::conv1d_relu
quantized::conv2d_prepack
quantized::linear_dynamic
quantized::linear_relu
quantized::relu6
torch_ipex::ipex_linear
torch_scatter::segment_mean_csr
@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Jan 21, 2025
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Jan 21, 2025
@itsbharatj
Copy link
Contributor

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@itsbharatj
Copy link
Contributor

Hey @mvafin thank you for this list for all the operations that have to be enabled. I would be very excited to work and implement many of these components.

Just for my understanding, is there any avaibilbe resource for the formula or description of the respective items?

@itsbharatj
Copy link
Contributor

Hey @mvafin thank you for this list for all the operations that have to be enabled. I would be very excited to work and implement many of these components.

Just for my understanding, is there any avaibilbe resource for the formula or description of the respective items?

Looking into the PyTorch Aten Library for more information on this. Would be great if you can post some other resources on the this, to better understand and contribute.

@darksapien23151
Copy link
Contributor

darksapien23151 commented Jan 21, 2025

hey!, @itsbharatj seems like a long list to go!
would be glad to be contributing along with you, kinda split the work for a faster progress?!

@mvafin is it possible that we could work together on it?

@itsbharatj
Copy link
Contributor

@darksapien23151 Definately! Would love to

@mvafin
Copy link
Contributor Author

mvafin commented Jan 22, 2025

@itsbharatj @darksapien23151 Please take one or two operations to work on. Do not take this issue. New issue will be created for operations you took.
I would recommend investigating the operation using pytorch documentation and code.
Please also write short description of how would you support this operation, write a formula you would use, OpenVINO operations that will be used in decomposition, etc.

@mvafin mvafin assigned mvafin and unassigned itsbharatj Jan 22, 2025
@darksapien23151
Copy link
Contributor

@mvafin aight, got it!

@geeky33
Copy link
Contributor

geeky33 commented Jan 24, 2025

@p-wysocki @mvafin

Greetings to both of you sir!
I am eager to work for this issue
since its a long enough
@p-wysocki sir asked me that I can work out on this issue's some of the selected operators

May I get the chance to work on

aten::equal
aten::Delete
aten::dict
aten::dot
aten::stack
aten::str
aten::take

Waiting for the positive response from both of you!

Do try to take a chance on me sir !

Thank you and Regards!!! :)

@mvafin
Copy link
Contributor Author

mvafin commented Jan 24, 2025

I removed aten::equal as it was already added.
aten::dict requires support for dicts in the frontend, so I wouldn't recommend starting from it. I would recommend you start from aten::dot as it seems to be easier operation

@geeky33
Copy link
Contributor

geeky33 commented Jan 24, 2025

okay sir
should I raise the issue and create the PR for it as it might get convenient for you to check on what selected operators I worked on!

Thanks for assigning me the issue!!

Regards!!

@darksapien23151
Copy link
Contributor

Good Day!
@mvafin ,
Hope you're doing great Sir! I've picked out some simpler operations to get started as you've mentioned:
aten::__contains__
aten::nan_to_num
aten::__is__
aten::__isnot__
aten::angle

Should I go forward as @geeky33 mentioned and create an issue and start off with?

@gatbontonp
Copy link

Hi @mvafin,

I picked up a few operations:
aten::stack
aten::vstack
aten::hstack
I also started writing aten::nan_to_num which would be combining the openvino operations IsNaN, IsInf, and Selects, but I see that @darksapien23151 also requested it.

@code-dev05
Copy link

Hi @mvafin
I would like to take on the aten::logit function for now.
It should be done using the log and subtract function.
Should I make a new issue for this function or just reference this issue in the pr?

@rtruong3775
Copy link

Hi @mvafin are there any functions left I can help contribute towards?

@Drazr
Copy link

Drazr commented Feb 1, 2025

Hi @mvafin can you assign any functions that are left unattended

@Mohamed-Ashraf273
Copy link

Mohamed-Ashraf273 commented Feb 2, 2025

Hey @mvafin
I hope you're doing great! I've picked out some simple operations to get started with:
aten::lshift
aten::rshift

Can I contribute to this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Contributors Needed
Development

No branches or pull requests

9 participants