[PDPD]Added and fixed Paddle convert. #28347
Open
+795
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build_jenkins |
|
Hi @ceciliapeng2011 Could you please take a review? Thanks! |
| #include "default_opset.hpp" | ||
| #include "openvino/frontend/paddle/node_context.hpp" | ||
| #include "openvino/opsets/opset15.hpp" | ||
| #include "openvino/opsets/opset4.hpp" |
There was a problem hiding this comment.
opset15 is back compatible to previous opsets. We can keep only opset15 header here.
| void normalize(std::vector<int64_t>& vec, const Output<Node> intput, const std::vector<int64_t> axes_vec) { | ||
| for (size_t i = 0; i < axes_vec.size(); i++) { | ||
| if (vec[i] < 0) { | ||
| auto x_dim = std::stoll(intput.get_partial_shape()[axes_vec[i]].to_string()); |
There was a problem hiding this comment.
Can we simply use
auto x_dim = intput.get_partial_shape()[axes_vec[i]];
here?
| for (int64_t i : vec) { | ||
| if (i < 0) | ||
| return true; | ||
| void normalize(std::vector<int64_t>& vec, const Output<Node> intput, const std::vector<int64_t> axes_vec) { |
There was a problem hiding this comment.
Suggested change
| void normalize(std::vector<int64_t>& vec, const Output<Node> intput, const std::vector<int64_t> axes_vec) { | |
| void normalize(std::vector<int64_t>& vec, const Output<Node> input, const std::vector<int64_t> axes_vec) { |
| return res; | ||
| } | ||
|
|
||
| Output<Node> get_1d_tensor(const Output<Node>& node) { |
There was a problem hiding this comment.
Do you meet any problem here without inserting unsqueeze node when node_dim == 0? OpenVINO supports scalar (rank==0).
| return res; | ||
| } | ||
|
|
||
| Output<Node> get_1d_tensor(const Output<Node>& node) { |
There was a problem hiding this comment.
The name "get_1d_tensor" sounds a bit mis-leading - it does not turn any tensor to 1D, right？Suggest change to something like "get_tensor_safe".
|
build_jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: