Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::fft_fftn #21665

Open
mvafin opened this issue Dec 14, 2023 · 9 comments
Open

[Good First Issue]: Support aten::fft_fftn #21665

mvafin opened this issue Dec 14, 2023 · 9 comments
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Dec 14, 2023

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases
  • Enable the model in model_hub_tests:
    google/fnet-base,fnet,xfail,Unsupported op aten::fft_fftn aten::real

Example Pull Requests

#17999

Resources

This will enable the google/fnet-base model from Hugging Face. You can use the following script to reproduce the issue:

from transformers import AutoTokenizer, AutoModel
from openvino import convert_model

tokenizer = AutoTokenizer.from_pretrained("google/fnet-base")
model = AutoModel.from_pretrained("google/fnet-base", torchscript=True)
text = "Replace me by any text you'd like."
encoded_input = tokenizer(text, return_tensors='pt', padding='max_length', truncation=True, max_length=512)
inputs = dict(encoded_input)

m = convert_model(model, example_input=inputs)

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

@mvafin mvafin added good first issue Good for newcomers no_stale Do not mark as stale labels Dec 14, 2023
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Dec 14, 2023
@mlukasze mlukasze added the category: PyTorch FE OpenVINO PyTorch Frontend label Dec 15, 2023
@siddhant-0707
Copy link
Contributor

siddhant-0707 commented Dec 15, 2023

.take
PR #21705

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@ilya-lavrenov ilya-lavrenov moved this from Contributors Needed to Assigned in Good first issues Dec 16, 2023
Copy link
Contributor

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

@mlukasze mlukasze moved this from Assigned to In Review in Good first issues Dec 21, 2023
@p-wysocki
Copy link
Contributor

I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

@mvafin
Copy link
Contributor Author

mvafin commented Feb 20, 2024

@siddhant-0707 Hi, do you have plans to finish PR, it will be removed soon, due to inactivity?

@mlukasze
Copy link
Contributor

awaiting response from contributor.
further actions based on his decision.

@mlukasze mlukasze moved this from In Review to Contributors Needed in Good first issues Jun 18, 2024
@hibahkhan2022
Copy link

.take

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Jan 9, 2025
@mvafin
Copy link
Contributor Author

mvafin commented Jan 17, 2025

@hibahkhan2022 Please pay attention that after the #28482 the implementation will be different. It can be implemented as an operation conversion, not as transformation.

@mvafin mvafin changed the title [Good First Issue]: Support aten::fft_fftn -> aten::real pattern [Good First Issue]: Support aten::fft_fftn Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Assigned
Development

Successfully merging a pull request may close this issue.

5 participants