-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Whisper static pipeline #1250
base: master
Are you sure you want to change the base?
Conversation
a1bab59
to
48cb438
Compare
With transformers 4.46.3 version encoder model have different dynamic shape for input_features, fix for StaticWhisperPipeline - PR #1293 |
e697a90
to
3bab16c
Compare
2fdac12
to
0e11d54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like everything can be covered by test_static_whisper_generation_compare_with_cpu
with different inputs (@pytest.mark.parametrize
)
"test_sample", get_samples_from_dataset(language="de", length=3) | ||
) | ||
@pytest.mark.precommit | ||
def test_static_whisper_language_de(model_descr, test_sample): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it actually check? How it's different from test_static_whisper_autodetect
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we explicitly set language in config, in test_static_whisper_autodetect
at first additional infer request will be called to detect language of the audio.
"test_sample", get_samples_from_dataset(language="fr", length=3) | ||
) | ||
@pytest.mark.precommit | ||
def test_static_whisper_language_fr(model_descr, test_sample): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question, how it's different from test_static_whisper_autodetect
3482704
to
09e1a99
Compare
Tested locally, all 17 tests passed with changes from #1469 |
Agree, tests code is similar. But decided to separate them as they cover different cases/functionality of static whisper pipeline. |
09e1a99
to
a1d0954
Compare
No description provided.