Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warning for a deletion not conforming to the 3' rule #585

Closed
leicray opened this issue Feb 13, 2024 · 5 comments
Closed

Incorrect warning for a deletion not conforming to the 3' rule #585

leicray opened this issue Feb 13, 2024 · 5 comments

Comments

@leicray
Copy link
Contributor

leicray commented Feb 13, 2024

Describe the bug
Validation of a variant description describing a deletion that does not conform to the 3' rule generates an incorrect warning.

To Reproduce
Validate the variant description NM_005445.3:c.717_719del

Expected behaviour
The warning that is displayed is NM_005445.3:c.717_719del automapped to NM_005445.3:c.720_722delTGA but should be NM_005445.3:c.717_719del automapped to NM_005445.3:c.720_722del.

This behaviour is observed with the interactive tool and the batch tool.

@ifokkema
Copy link
Collaborator

Note that #584 suggests the idea of tossing these "automapping" messages altogether, as they are meant for internal use only.

@leicray
Copy link
Contributor Author

leicray commented Feb 13, 2024

I'm not sure what you mean by "...they are meant for internal use only."

They are certainly of use to users of the interactive validator who might otherwise not understand that the validated output does not correspond to the submitted variant because of the 3' rule being applied. I would argue that the same is also true for the batch tool. The only place where it is perhaps not needed is tools whose output is intended to be solely machine-readable.

@ifokkema
Copy link
Collaborator

I agree that some form of warning should be shown, indicating the original input wasn't correct.

@Peter-J-Freeman
Copy link
Collaborator

OK, I see now why we included these warnings. I need to trim them. The thing is though that not all may be perfect.

@Peter-J-Freeman
Copy link
Collaborator

Fixed. Needs server update to take effect. Be patient please @leicray :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants