-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement in-process context propagation #43
Comments
I propose not to introduce the in-process context propagation feature until the release v2.0.0. |
without in process propagation opentracing is useless. there is no easy way to access the current span deep in your code and especially not within third party libraries. |
Yes.
No, absolutely! Tracing the current span with a stack like array is not so hard as you imagine. I agree that in process propagation opentracing is a great convenient. However, as @yurishkuro said in the issue opentracing/specification#23,
It is no doubt that the OT spec will support the in process propagation opentracing. However, the the issue opentracing/specification#23 is added to the OpenTracing 2.0 milestone. So as a PHP-version of the OT-spec, we should release our v1.0 as soon as possible. And the feature of in process propagation opentracing should be added in our v2.0 as well. |
@lvht I strongly believe not including In the other hand, since there is a lot of effort around supporting IPCP in all languages (except golang) we will support that very soon, meaning that all the effort spent on instrumenting use cases passing the context (which is an overhead in terms of development) will be a waste of time. |
@jcchavezs I propose to froze the current API by making a v1.0.0 release, and finish the current stable milestone. All other features discussing can be added in the future v1.x or v2.x. |
ping @jcchavezs The 2018 is coming |
ping @jcchavezs |
1 similar comment
ping @jcchavezs |
Background
OpenTracing API aims to provide interfacing for in-process context propagation. After several discussions in the Java repo, finally OT has a clear design for it.
Proposal
There is a PR in Python aiming to fix this. We might ship something very similar.
Questions to address
active span
with respect to the current one?Ping @tedsuo @felixfbecker @beberlei @lvht
The text was updated successfully, but these errors were encountered: