Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items with similar names affecting "monster.loot" drops. #3217

Open
2 of 5 tasks
ctlsEx opened this issue Jan 4, 2025 · 4 comments
Open
2 of 5 tasks

Items with similar names affecting "monster.loot" drops. #3217

ctlsEx opened this issue Jan 4, 2025 · 4 comments
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ctlsEx
Copy link

ctlsEx commented Jan 4, 2025

Priority

Medium

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

Exemple:

<item id="39233" article="an" name="enchanted turtle amulet">
<item id="39234" article="an" name="enchanted turtle amulet">

When killing the boss "Timira the Many-Headed", no items were dropping, and no errors appeared in the terminal.

I attempted various configurations in the monster.loot file, using both id and name, but the issue persisted.

However, after modifying the item name in the items.xml file as follows:

from:
<item id="39233" article="an" name="enchanted turtle amulet">
To:
<item id="39233" article="an" name="enchantedd turtle amulet">

The drops began to work correctly, regardless of whether id or name was used in the configuration.

  • Note:
    I tested this issue only with the boss Timira the Many-Headed and have not tested it with other monsters or non-boss creatures.

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ctlsEx ctlsEx added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 4, 2025
@github-actions github-actions bot added Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing labels Jan 4, 2025
@Nyedson
Copy link
Contributor

Nyedson commented Jan 5, 2025

The loot of "enchanted turtle amulet" on Timira is using ID:
{ id = 39233, chance = 200 }, -- enchanted turtle amulet

The duplicate name should be irrelevant.

@ctlsEx
Copy link
Author

ctlsEx commented Jan 5, 2025

I understand that the duplicate name shouldn't matter, but it caused this error.

I tested the drop using both id and name and it only started working again after changing the item's name.

Does this error occur for you as well? Have you tested it?

@Nyedson
Copy link
Contributor

Nyedson commented Jan 5, 2025

I understand that the duplicate name shouldn't matter, but it caused this error.

I tested the drop using both id and name and it only started working again after changing the item's name.

Does this error occur for you as well? Have you tested it?

Tested and work normally: Using a player, kill the boss, check the loot (even put loot chance 100000 in the amulet to see it in the drop).

However, my source is dated to before 05/12/2024 (because i use windows and no compiled again).

But, the correct is duplicate name should be irrelevant if use ID in loot.

@dudantas
Copy link
Member

dudantas commented Jan 5, 2025

What you reported doesn't seem to make sense. If an item is registered with the wrong name or id, it will report this in the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be impactful and needs some attention. Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants