Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handler to propagate errors prior to JOIN_FIN.req #29

Open
jwhui opened this issue Mar 11, 2020 · 1 comment
Open

Handler to propagate errors prior to JOIN_FIN.req #29

jwhui opened this issue Mar 11, 2020 · 1 comment
Assignees
@wgtdkp
Labels
p2

Comments

@jwhui
Copy link
Member

jwhui commented Mar 11, 2020

The current handler is invoked after receiving a JOIN_FIN.req:

ot-commissioner/src/library/commissioning_session.cpp

Line 203 in 8b8ad47

accepted = mCommImpl.mCommissioningHandler(

It would be useful to propagate any errors (see #28 for example) that occur prior to receiving the JOIN_FIN.req to the user.
@wgtdkp
Copy link
Member

wgtdkp commented Mar 12, 2020

Agree.

@wgtdkp wgtdkp self-assigned this Mar 12, 2020
@wgtdkp wgtdkp added the p2 label Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wgtdkp wgtdkp

Labels
p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wgtdkp @jwhui