Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated entries from response #112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anton-sidelnikov
Copy link
Member

@anton-sidelnikov anton-sidelnikov commented Jun 20, 2022

In case when two types of loadbalancers in one region, the entries from lister is duplicated
Closes #110

@anton-sidelnikov anton-sidelnikov self-assigned this Jun 20, 2022
@anton-sidelnikov anton-sidelnikov added the bug Something isn't working label Jun 20, 2022
Copy link
Member

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really know. Technically this is wrong. It is not correct for one provider to return also results for the other. Provider deployment should be changed not to do this. In addition to that: once one provider returns results of another one there is no guarantee you get proper values (since due to the interface change there might be some fields missing or populated wrongly).

@gtema
Copy link
Member

gtema commented Jun 20, 2022

can we maybe filter out those, that came with provider property not matching which provider did actually returned it?

@anton-sidelnikov
Copy link
Member Author

I do not really know. Technically this is wrong. It is not correct for one provider to return also results for the other. Provider deployment should be changed not to do this. In addition to that: once one provider returns results of another one there is no guarantee you get proper values (since due to the interface change there might be some fields missing or populated wrongly).

Yes, I agree that this behavior is wrong. So i decided just to pop out the duplicated ids from list

@anton-sidelnikov
Copy link
Member Author

can we maybe filter out those, that came with provider property not matching which provider did actually returned it?

it hard to distinguish, because each provider marks results as his own
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ELBV2] openstack loadbalancer pool list returns empty list
2 participants