Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScheduleFile entries in My Model for tabs where missing (eg: Loads) #796

Open
jmarrec opened this issue Mar 10, 2025 · 1 comment · May be fixed by #797
Open

Add ScheduleFile entries in My Model for tabs where missing (eg: Loads) #796

jmarrec opened this issue Mar 10, 2025 · 1 comment · May be fixed by #797
Assignees
@jmarrec
Labels
component - UI good first issue Good for newcomers severity - Minor Bug 🐤

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Mar 10, 2025

Issue overview

But you can't use that schedule on some/most tabs, for eg the Space Type "Loads".

Current Behavior

Image

Expected Behavior

Should be able to use it.

Steps to Reproduce

  1. Import a schedule:file into OSApp
  2. Go to SpaceType, Loads, see the "My Model" has no entry for ScheduleFile so you can't select it.

Possible Solution

Adjust MainRightColumnController.cpp

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version): All
  • Version of OpenStudioApplication (if using an intermediate build, include SHA): 1.9.0

Context

Reported on UH here: https://unmethours.com/question/101294/help-with-custom-schedule-from-file/
@jmarrec jmarrec added component - UI Enhancement Request New feature or request good first issue Good for newcomers severity - Minor Bug 🐤 and removed Enhancement Request New feature or request labels Mar 10, 2025
@jmarrec
Copy link
Collaborator Author

jmarrec commented Mar 10, 2025

At least here:

OpenStudioApplication/src/openstudio_lib/MainRightColumnController.cpp

Lines 534 to 540 in 821c858

myModelList->addModelObjectType(IddObjectType::OS_Schedule_VariableInterval, "Variable Interval Schedules");
myModelList->addModelObjectType(IddObjectType::OS_Schedule_FixedInterval, "Fixed Interval Schedules");
myModelList->addModelObjectType(IddObjectType::OS_Schedule_Year, "Year Schedules");
myModelList->addModelObjectType(IddObjectType::OS_Schedule_Constant, "Constant Schedules");
myModelList->addModelObjectType(IddObjectType::OS_Schedule_Compact, "Compact Schedules");
myModelList->addModelObjectType(IddObjectType::OS_Schedule_Ruleset, "Ruleset Schedules");
myModelList->addModelObjectCategoryPlaceholder("Schedules");

jmarrec added a commit that referenced this issue Mar 10, 2025
@jmarrec
Fix #796 - Add ScheduleFile to MainRightColumnController
7450382
@jmarrec jmarrec self-assigned this Mar 10, 2025
@jmarrec jmarrec linked a pull request Mar 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - UI good first issue Good for newcomers severity - Minor Bug 🐤
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #796 - Add ScheduleFile to MainRightColumnController openstudiocoalition/OpenStudioApplication
1 participant
@jmarrec