Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable commenting when reactivating note? #5444

Open
nenad-vujicic opened this issue Dec 26, 2024 · 1 comment
Open

Enable commenting when reactivating note? #5444

nenad-vujicic opened this issue Dec 26, 2024 · 1 comment

Comments

@nenad-vujicic
Copy link
Contributor

Problem

Not sure if this is a feature or a bug, but when note is closed, logged-in users are unable to add a comment when reactivating note. It looks like backend already supports adding comment when reactivating (processing of text API::NotesController#reopen). Perhaps it could be usable to mappers to have this ability to describe why they are reactivating some note?

Description

Do we need to display text-box for entering comment when reactivating note if user is logged-in?

Screenshots

image

@AntonKhorev
Copy link
Collaborator

I thought about this when #5359 was discovered. Always having a textarea would have fixed that bug.

I don't know why there's no comment input for closed noted, but it looks like a deliberate choice. When commenting was first added to the web ui there was no reopen action available d57755b. Later reopen was added d74d4f8 and right after that the ui for it with a hidden comment input 02d9584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants