-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detached House no longer searchable in feature list #1438
Comments
@samscodeco could you check the translations https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#translating to see if maybe the default english was changed (American English) and nothing was added to British English? |
The translation was changed in Transifex and added to iD in this commit. I've reverted the following incorrect translations by the same user: Detached House -> Freestanding House |
@andrewharvey it looks like those changes where from your account? Is there anything left to do here, maybe apply the translations elsewhere. Otherwise it sounds like we can close this. The change will be released with the next update of iD. |
Sorry that's my mistake, I meant to edit |
@tyrasd is there something we can do to speed up the translation update in production? (Still don't quite understand what is pulled automatically where...) |
As an aside to this issue, especially when working on en_AU translations I feel it would be easier to manage them directly in GitHub as PRs rather than Transifex. It would give each change a proper review, a space for discussion, voting and to store a record of those discussions for future reference. |
Describe the bug
"Detached House" is no longer searchable in the feature list.
building=detached
shows up as "Freestanding House" (not the correct term in British English).To Reproduce
Set language to en-GB, create or edit an area, search for "Detached House" in the feature list.
Expected behavior
"Detached House" present in the feature list.
Screenshots
![Image](https://private-user-images.githubusercontent.com/64515682/410920203-52a322fe-5a76-4f87-927e-2af7e2dcd160.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NDkwNDEsIm5iZiI6MTczOTU0ODc0MSwicGF0aCI6Ii82NDUxNTY4Mi80MTA5MjAyMDMtNTJhMzIyZmUtNWE3Ni00Zjg3LTkyN2UtMmFmN2UyZGNkMTYwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE0VDE1NTkwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3NjJhYjg5MWVjNTFiMjk3MTBmZWRhMjdkYWQ3MjdiZGM5NTk5YTEwYmY4ZDA5NDhkYjg1NDY2N2M0ZDk1NjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.r6N5G4CcZn06gedAeMrN-BAgL9mKdUrvncRYTVrPqIE)
The text was updated successfully, but these errors were encountered: