Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detached House no longer searchable in feature list #1438

Open
samscodeco opened this issue Feb 7, 2025 · 6 comments
Open

Detached House no longer searchable in feature list #1438

samscodeco opened this issue Feb 7, 2025 · 6 comments
Labels
bug Something isn't working translations this is an issue with a translation, which needs to be solved on the transifex platform

Comments

@samscodeco
Copy link

samscodeco commented Feb 7, 2025

Describe the bug
"Detached House" is no longer searchable in the feature list. building=detached shows up as "Freestanding House" (not the correct term in British English).

To Reproduce
Set language to en-GB, create or edit an area, search for "Detached House" in the feature list.

Expected behavior
"Detached House" present in the feature list.

Screenshots
Image

@samscodeco samscodeco added bug Something isn't working needs-triage This is a fresh issue which has not yet been looked over by the maintainers of this repository. labels Feb 7, 2025
@tordans
Copy link
Collaborator

tordans commented Feb 7, 2025

@samscodeco could you check the translations https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#translating to see if maybe the default english was changed (American English) and nothing was added to British English?

@tordans tordans added translations this is an issue with a translation, which needs to be solved on the transifex platform and removed needs-triage This is a fresh issue which has not yet been looked over by the maintainers of this repository. labels Feb 7, 2025
@samscodeco
Copy link
Author

The translation was changed in Transifex and added to iD in this commit. I've reverted the following incorrect translations by the same user:

Detached House -> Freestanding House
Jetway -> Aerobridge
Barbecue -> Barbeque

@tordans
Copy link
Collaborator

tordans commented Feb 7, 2025

@andrewharvey it looks like those changes where from your account? Is there anything left to do here, maybe apply the translations elsewhere.

https://app.transifex.com/openstreetmap/id-editor/translate/#en_GB/$/449668774?q=translation_text%3Adetached

Otherwise it sounds like we can close this. The change will be released with the next update of iD.

@andrewharvey
Copy link
Contributor

Sorry that's my mistake, I meant to edit en_AU but somehow edited en_GB instead. I think what happened is Transifex started defaulting me to en_GB, instead of en_AU.

@tordans
Copy link
Collaborator

tordans commented Feb 8, 2025

@tyrasd is there something we can do to speed up the translation update in production? (Still don't quite understand what is pulled automatically where...)

@andrewharvey
Copy link
Contributor

As an aside to this issue, especially when working on en_AU translations I feel it would be easier to manage them directly in GitHub as PRs rather than Transifex. It would give each change a proper review, a space for discussion, voting and to store a record of those discussions for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working translations this is an issue with a translation, which needs to be solved on the transifex platform
Projects
None yet
Development

No branches or pull requests

3 participants