Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop password managers from autofilling address fields #10507

Open
michaelabon opened this issue Oct 18, 2024 · 0 comments · May be fixed by #10508
Open

Stop password managers from autofilling address fields #10507

michaelabon opened this issue Oct 18, 2024 · 0 comments · May be fixed by #10508

Comments

@michaelabon
Copy link

michaelabon commented Oct 18, 2024 •
edited
Loading

Description

I am a 1Password user (and employee). Whenever I am editing a local business's details in iD, I am frustrated that the 1Password browser extension offers to fill out my personal address instead of the business's address.

I don't work on our browser extension, I could not tell you why every password manager has their own custom data attribute
when autocomplete=off exists.

I was very pleased to find out that there was already a well-used utility function
to disable autocomplete/autocorrect/autocapitalize in modules/util/util.js under the utilNoAuto function. So, I already have a working commit that would address this for 1Password, Bitwarden, Dashlane, and LastPass. It extends what was already built in #3839 and #5818.

Screenshots

Screenshot 2024-10-18 at 12 16 32
michaelabon added a commit to michaelabon/iD that referenced this issue Oct 18, 2024
@michaelabon
Stop password managers from autofilling address fields
6ffba9f 
I am a 1Password user (and employee).
Whenever I am editing a local business's details in iD,
I am frustrated that the 1Password browser extension offers
to fill out my personal address
instead of the business's address.

I don't work on our browser extension,
I could not tell you why every password manager
has their own custom data attribute
when autocomplete=off exists.
But, for fairness,
I am including other major password managers'
custom data attributes to stop them as well
from autofilling address fields.

I was very pleased to find out that
there was already
a well-used utility function
to disable autocomplete/autocorrect/autocapitalize.

Fixes openstreetmap#10507
@michaelabon michaelabon linked a pull request Oct 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop password managers from autofilling address fields michaelabon/iD
1 participant
@michaelabon