Don't suggest values from Taginfo for name:xx tags

[Dimitar5555]

URL

No response

How to reproduce the issue?

1. Create an element
2. Go to it's tags
3. Add name:xx
4. Switch to the value box
5. Start typing
6. (notice the suggestions below)

Screenshot(s) or anything else?

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.29.0

Which browsers are you seeing this problem on?

Firefox

[1ec5]

Related discussion: #7485.

There’s a hard-coded list of keys that don’t get taginfo suggestions. It could be supplemented by a regular expression for keys starting with name:.

iD/modules/services/taginfo.js

Lines 196 to 209 in 49492a0

	_popularKeys = {
	// manually exclude some keys – #5377, #7485
	postal_code: true,
	full_name: true,
	loc_name: true,
	reg_name: true,
	short_name: true,
	sorting_name: true,
	artist_name: true,
	nat_name: true,
	long_name: true,
	via: true,
	'bridge:name': true
	};

[draunger]

@1ec5 @Dimitar5555 can I start working on it if no one is doing it??

[1ec5]

I don’t think anyone has submitted a pull request about this issue so far. (You’d see a link to it somewhere on this page.) Feel free to submit a PR once you’ve got something that you’d like feedback about, and we’ll try to respond when we’re able to.

[1ec5]

By the way, I noted above that we’re hard-coding a list of “popular” keys to ignore, but there’s a large, technically unbounded number of possible name:* keys. So rather than trying to enumerate all of them, consider looking at where this _popularKeys variable is used and adjusting the logic there.

[draunger]

@1ec5 ok sir

[draunger]

hey @1ec5 i have done this issue and here the PR of this issue #10521 you can review that PR as soon as possible.