Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manila-generic with manila-ganesha #702

Open
pmatulis opened this issue Feb 7, 2022 · 1 comment
Open

Replace manila-generic with manila-ganesha #702

pmatulis opened this issue Feb 7, 2022 · 1 comment

Comments

@pmatulis
Copy link
Contributor

pmatulis commented Feb 7, 2022

In upgrade_utils.py I think that manila-generic should be replaced with manila-ganesha.

@ajkavanagh
Copy link
Collaborator

I don't think it should be. In our tests, we still want to check that a subordinate to manila can be upgraded. manila-generic is a test charm, that is a sub to manila, but that carries very little baggage or configuration with it. Hence it's quite useful.

There might be an argument that ganesha should be added to the tests, but not as a replacement for manila-generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants