Merge ML-KEM feature branch

[vavroch2010]

No description provided.

[mattcaswell]

@baentsch the checklist I was talking about is here:

https://openssl-library.org/policies/technical/release-requirements/

We should consider whether some adaptation of this is appropriate for merging of feature branches.

[baentsch]

Thanks for sharing @mattcaswell .

We should consider whether some adaptation of this is appropriate for merging of feature branches.

I would think so: I have the impression that these lists mainly cater for "steady state evolution", am I wrong there?

One concrete statement is "OTC/OMC-set objectives" have to be met: Where are those documented for this feature branch?

The other is that coverage should be at least as good as the one for master. Can you provide a pointer how/where to check this? Looking at https://coveralls.io/github/openssl/openssl I didn't find a run on this feature branch: Does that have to be configured? How?

[mattcaswell]

One concrete statement is "OTC/OMC-set objectives" have to be met: Where are those documented for this feature branch?

Well this is one area where I think that checklist needs an update. That was written at a time before we had time-based releases, i.e. we were doing feature based releases and therefore we wouldn't release until the feature that was targeted for the release was complete. This is of course no longer the case (and not to mention that the OMC no longer exists!).

The other is that coverage should be at least as good as the one for master. Can you provide a pointer how/where to check this? Looking at https://coveralls.io/github/openssl/openssl I didn't find a run on this feature branch: Does that have to be configured? How?

See: https://github.com/openssl/openssl/blob/master/.github/workflows/coveralls.yml

Not sure if there is anything else that needs to be done. I suppose there is the question of whether we want this for all feature branches. I imagine over time we are going to create a lot of feature branches.

[baentsch]

Well this is one area where I think that checklist needs an update.

Are you going to initiate that? Anything I can/should do?

See: https://github.com/openssl/openssl/blob/master/.github/workflows/coveralls.yml

Thanks for the pointer. Documents that feature/ml-kem is not part of the test, right?

Not sure if there is anything else that needs to be done. I suppose there is the question of whether we want this for all feature branches. I imagine over time we are going to create a lot of feature branches.

IMO, feature branches that are slated for inclusion in the next release should be part of that list such as to get timely notifications as to whether coverage is good enough for merge or more work is needed.