Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait on short type? #482

Open
manjugv opened this issue Oct 27, 2021 · 5 comments
Open

Wait on short type? #482

manjugv opened this issue Oct 27, 2021 · 5 comments

Comments

@manjugv
Copy link
Collaborator

manjugv commented Oct 27, 2021

void shmem_wait_until(TYPE *ivar, int cmp, TYPE cmp_value);

Please see page 112 in the OpenSHMEM v1.5 document. It seems like by referring to Table 6, we are deprecating the wait on type short and unsigned short, was this intentional?

@manjugv
Copy link
Collaborator Author

manjugv commented Oct 27, 2021

@naveen-rn @nspark

@davidozog
Copy link
Collaborator

I seem to recall it was intentionally deprecated (see pg. 160 - Section F.2.16), because shmem_wait and shmem_test are only compatible with AMOs, and short and unsigned short are not compatible AMO types.

Also isn't it true that some transports (e.g. UCX, ibv) don't have direct support for 16-bit atomics?

@nspark
Copy link
Contributor

nspark commented Oct 27, 2021

Yes, It was an intentional deprecation. @davidozog hits the rationale on point. I also see this as part of our incremental progress toward defining a memory model.

In my recent explorations with UCX, I recall it only exposes 32- and 64-bit AMOs.

@naveen-rn
Copy link
Contributor

Agreed - this was an intentional deprecation. AFAIU, there are no 16b AMOs and since only waits and tests are compatible with AMOs and PWS - we decided to deprecate shorts.

@nspark
Copy link
Contributor

nspark commented Mar 23, 2022

@manjugv Is this good to close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants