-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change rmInjectionScript location #1097
Change rmInjectionScript location #1097
Conversation
Update the rmInjectionScript location to `/var/rm-inejections` Fixes #1065
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @adambkaplan |
Generally looks good. However, I'd like to have some certainty that this won't break things with an e2e test. I think the ci/openshift-jenkins/jenkins-s2i test will perm-fail, I'm 95% sure that server was decomissioned. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
could we reopen and merge this? |
/reopen |
@ricoms: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
Update the rmInjectionScript location to
/var/rm-inejections
Fixes #1065