Skip to content

Commit d1f9b27

Browse files
committed
bump(k8s): compile fixes
1 parent 7eb3749 commit d1f9b27

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

pkg/config/serving/server.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@ import (
1414
"k8s.io/apimachinery/pkg/version"
1515
genericapiserver "k8s.io/apiserver/pkg/server"
1616
genericapiserveroptions "k8s.io/apiserver/pkg/server/options"
17+
"k8s.io/apiserver/pkg/util/compatibility"
1718
"k8s.io/client-go/kubernetes"
18-
kasversion "k8s.io/component-base/version"
19+
kasversioncompatibility "k8s.io/component-base/compatibility"
1920
"k8s.io/klog/v2"
2021

2122
configv1 "github.com/openshift/api/config/v1"
@@ -110,13 +111,14 @@ func assertAPIConnection(ctx context.Context, kubeClient *kubernetes.Clientset,
110111
// DefaultBuildEffectiveVersion returns the MutableEffectiveVersion based on the
111112
// current build information.
112113
// Similar to version.DefaultBuildEffectiveVersion
113-
func defaultBuildEffectiveVersion(versionInfo *version.Info) kasversion.MutableEffectiveVersion {
114+
// See https://github.com/kubernetes/apiserver/commit/9bb4aa730abaf73aaef17dc9e9608cceb4f904ed#diff-bc93e77a314d3da08bb793695b142f4f32d4e3fdd186fe22c87725d8dec62130R51-R55
115+
func defaultBuildEffectiveVersion(versionInfo *version.Info) kasversioncompatibility.MutableEffectiveVersion {
114116
if versionInfo != nil {
115117
// major.minor passed through gitVersion
116118
parsedVersion, err := utilversion.Parse(versionInfo.String())
117119
if err == nil && (parsedVersion.Major() != 0 || parsedVersion.Minor() != 0) {
118-
return kasversion.NewEffectiveVersion(versionInfo.String())
120+
return kasversioncompatibility.NewEffectiveVersionFromString(versionInfo.String(), "", "")
119121
}
120122
}
121-
return kasversion.DefaultKubeEffectiveVersion()
123+
return compatibility.DefaultBuildEffectiveVersion()
122124
}

pkg/operator/v1helpers/test_helpers.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ func (i fakeSharedIndexInformer) AddEventHandlerWithResyncPeriod(handler cache.R
3737
return nil, nil
3838
}
3939

40+
func (i fakeSharedIndexInformer) AddEventHandlerWithOptions(handler cache.ResourceEventHandler, options cache.HandlerOptions) (cache.ResourceEventHandlerRegistration, error) {
41+
return nil, nil
42+
}
43+
4044
func (i fakeSharedIndexInformer) RemoveEventHandler(handle cache.ResourceEventHandlerRegistration) error {
4145
panic("implement me")
4246
}
@@ -57,6 +61,10 @@ func (fakeSharedIndexInformer) Run(stopCh <-chan struct{}) {
5761
panic("implement me")
5862
}
5963

64+
func (fakeSharedIndexInformer) RunWithContext(ctx context.Context) {
65+
panic("implement me")
66+
}
67+
6068
func (fakeSharedIndexInformer) HasSynced() bool {
6169
return true
6270
}
@@ -77,6 +85,10 @@ func (fakeSharedIndexInformer) SetWatchErrorHandler(handler cache.WatchErrorHand
7785
panic("implement me")
7886
}
7987

88+
func (fakeSharedIndexInformer) SetWatchErrorHandlerWithContext(handler cache.WatchErrorHandlerWithContext) error {
89+
panic("implement me")
90+
}
91+
8092
func (fakeSharedIndexInformer) SetTransform(f cache.TransformFunc) error {
8193
panic("implement me")
8294
}

0 commit comments

Comments
 (0)