Skip to content

Commit 7ac84db

Browse files
committed
PUDN, static ips: add test plan, and graduation criteria sections
Signed-off-by: Miguel Duarte Barroso <[email protected]>
1 parent 3324e38 commit 7ac84db

File tree

1 file changed

+17
-72
lines changed

1 file changed

+17
-72
lines changed

enhancements/network/routed-ingress-support-for-primary-udn-attached-vms-with-static-ips.md

Lines changed: 17 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -668,78 +668,33 @@ to implement the design. For instance,
668668

669669
## Test Plan
670670

671-
**Note:** *Section not required until targeted at a release.*
672-
673-
Consider the following in developing a test plan for this enhancement:
674-
- Will there be e2e and integration tests, in addition to unit tests?
675-
- How will it be tested in isolation vs with other components?
676-
- What additional testing is necessary to support managed OpenShift service-based offerings?
677-
678-
No need to outline all of the test cases, just the general strategy. Anything
679-
that would count as tricky in the implementation and anything particularly
680-
challenging to test should be called out.
681-
682-
All code is expected to have adequate tests (eventually with coverage
683-
expectations).
671+
* E2E upstream and downstream jobs covering VM creation with requested
672+
IP/MAC/gateway configuration for both IPv4 and dual-stack configurations
673+
* E2E downstream jobs covering a VM (having a network configuration which must
674+
be kept) import via MTV is successful for both IPv4 and dual-stack
675+
configurations
676+
* E2E tests covering the existing features (network policies, IP spoof
677+
protection, services) for an imported VM works as expected for both IPv4 and
678+
dual-stack configurations
684679

685680
## Graduation Criteria
686681

687-
**Note:** *Section not required until targeted at a release.*
688-
689-
Define graduation milestones.
690-
691-
These may be defined in terms of API maturity, or as something else. Initial proposal
692-
should keep this high-level with a focus on what signals will be looked at to
693-
determine graduation.
694-
695-
Consider the following in developing the graduation criteria for this
696-
enhancement:
697-
698-
- Maturity levels
699-
- [`alpha`, `beta`, `stable` in upstream Kubernetes][maturity-levels]
700-
- `Dev Preview`, `Tech Preview`, `GA` in OpenShift
701-
- [Deprecation policy][deprecation-policy]
702-
703-
Clearly define what graduation means by either linking to the [API doc definition](https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-versioning),
704-
or by redefining what graduation means.
705-
706-
In general, we try to use the same stages (alpha, beta, GA), regardless how the functionality is accessed.
707-
708-
[maturity-levels]: https://git.k8s.io/community/contributors/devel/sig-architecture/api_changes.md#alpha-beta-and-stable-versions
709-
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/
710-
711-
**If this is a user facing change requiring new or updated documentation in [openshift-docs](https://github.com/openshift/openshift-docs/),
712-
please be sure to include in the graduation criteria.**
713-
714-
**Examples**: These are generalized examples to consider, in addition
715-
to the aforementioned [maturity levels][maturity-levels].
716-
717682
### Dev Preview -> Tech Preview
718683

719-
- Ability to utilize the enhancement end to end
720-
- End user documentation, relative API stability
721-
- Sufficient test coverage
722-
- Gather feedback from users rather than just developers
723-
- Enumerate service level indicators (SLIs), expose SLIs as metrics
724-
- Write symptoms-based alerts for the component(s)
684+
There will be no Dev Preview for this feature.
725685

726686
### Tech Preview -> GA
727687

728-
- More testing (upgrade, downgrade, scale)
729-
- Sufficient time for feedback
730-
- Available by default
731-
- Backhaul SLI telemetry
732-
- Document SLOs for the component
733-
- Conduct load testing
734-
- User facing documentation created in [openshift-docs](https://github.com/openshift/openshift-docs/)
735-
736-
**For non-optional features moving to GA, the graduation criteria must include
737-
end to end tests.**
688+
Targeting GA in OCP version 4.20.
738689

739690
### Removing a deprecated feature
740691

741-
- Announce deprecation and support policy of the existing feature
742-
- Deprecate the feature
692+
The annotation currently being used for indicating to OVN-Kubernetes what is
693+
the `IPAMClaim` to use for the primary UDN attachment will be deprecated, and
694+
we plan on using the [multus default annotation](#cnv-ovnk-api) for it.
695+
696+
The deprecation strategy is described in the OVN-Kubernetes
697+
[OKEP](https://github.com/ovn-kubernetes/ovn-kubernetes/pull/5238).
743698

744699
## Upgrade / Downgrade Strategy
745700

@@ -784,17 +739,7 @@ Downgrade expectations:
784739

785740
## Version Skew Strategy
786741

787-
How will the component handle version skew with other components?
788-
What are the guarantees? Make sure this is in the test plan.
789-
790-
Consider the following in developing a version skew strategy for this
791-
enhancement:
792-
- During an upgrade, we will always have skew among components, how will this impact your work?
793-
- Does this enhancement involve coordinating behavior in the control plane and
794-
in the kubelet? How does an n-2 kubelet without this feature available behave
795-
when this feature is used?
796-
- Will any other components on the node change? For example, changes to CSI, CRI
797-
or CNI may require updating that component before the kubelet.
742+
N/A
798743

799744
## Operational Aspects of API Extensions
800745

0 commit comments

Comments
 (0)