Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-18603: Add OCI controller implemented with oracle API #2526

Merged
merged 1 commit into from
Oct 29, 2024
Merged

MGMT-18603: Add OCI controller implemented with oracle API #2526

merged 1 commit into from
Oct 29, 2024

Conversation

bkopilov
Copy link
Contributor

@bkopilov bkopilov commented Sep 7, 2024

This patch allow us decouple terraform code from cluster testing. Terraform provided by oracle and maintained by them. Terraform version / code may be updated by oracle .

We run the test same as customer , created support for the next steps:

  1. Create a bucket (object-storage)
  2. Upload ISO file to the object-storage bucket
  3. Create pre authenticated - return ISO download link from OCI storage
  4. Create a stack , declare the provision configuration.
  5. Upload infrastructure zip file to the stack and set terraform variable
  6. Start running job creating oci nodes discovered by redhat cluster and return terraform output files
  7. Once nodes are discovered we configure manifest return in README fixes #6

We handle cleanup on teardown , running destory .

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 7, 2024

Hi @bkopilov. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bkopilov bkopilov changed the title Add OCI controller implemented with oracle API code. DRAFT: Add OCI controller implemented with oracle API code. Sep 7, 2024
@bkopilov
Copy link
Contributor Author

bkopilov commented Sep 7, 2024

@adriengentil , @mburman5 , @talhil-rh , @eifrach , @AlonaKaplan

@bkopilov
Copy link
Contributor Author

bkopilov commented Sep 7, 2024

POC code , need to add terraform.zip support (download) ...

@bkopilov bkopilov force-pushed the oci_api_controller branch 2 times, most recently from aba5fcd to d20030c Compare September 12, 2024 04:13
@adriengentil
Copy link
Contributor

/ok-to-test
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2024
@bkopilov
Copy link
Contributor Author

I dont think it will work ... need to tune the terraform zip file before.
Maybe we can start review in steps till we have full picture and proper configuration

@adriengentil adriengentil marked this pull request as draft September 12, 2024 07:58
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2024
@adriengentil
Copy link
Contributor

I dont think it will work ... need to tune the terraform zip file before. Maybe we can start review in steps till we have full picture and proper configuration

I set the PR as draft

adriengentil
adriengentil reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@adriengentil adriengentil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just small comments

skipper.env Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
src/assisted_test_infra/test_infra/controllers/node_controllers/oci_api_controller.py Outdated Show resolved Hide resolved
@adriengentil adriengentil marked this pull request as ready for review October 10, 2024 15:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2024
@rccrdpccl
Copy link
Contributor

/uncc @rccrdpccl

@openshift-ci openshift-ci bot removed the request for review from rccrdpccl October 15, 2024 15:51
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 28, 2024
@bkopilov
Copy link
Contributor Author

Added sample of test_case to be used.
https://gitlab.cee.redhat.com/ocp-edge-qe/kni-assisted-installer-auto/-/merge_requests/1380

adriengentil
adriengentil reviewed Oct 28, 2024
View reviewed changes
skipper.env Outdated Show resolved Hide resolved
adriengentil
adriengentil reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@adriengentil adriengentil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left just one nit and the lint job has to be fixed

@adriengentil
Copy link
Contributor

adriengentil commented Oct 29, 2024 •
edited by openshift-ci bot
Loading

/retitle MGMT-18603: Add OCI controller implemented with oracle API

@openshift-ci openshift-ci bot changed the title DRAFT: Add OCI controller implemented with oracle API code. MGMT-18603: Add OCI controller implemented with oracle API Oct 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2024 •
edited by openshift-ci bot
Loading

@bkopilov: This pull request references MGMT-18603 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

This patch allow us decouple terraform code from cluster testing. Terraform provided by oracle and maintained by them. Terraform version / code may be updated by oracle .

We run the test same as customer , created support for the next steps:

  1. Create a bucket (object-storage)
  2. Upload ISO file to the object-storage bucket
  3. Create pre authenticated - return ISO download link from OCI storage
  4. Create a stack , declare the provision configuration.
  5. Upload infrastructure zip file to the stack and set terraform variable
  6. Start running job creating oci nodes discovered by redhat cluster and return terraform output files
  7. Once nodes are discovered we configure manifest return in README fixes #6

We handle cleanup on teardown , running destory .

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2024
@bkopilov bkopilov force-pushed the oci_api_controller branch 2 times, most recently from d1faaf7 to 40aa76a Compare October 29, 2024 10:56
@bkopilov
Copy link
Contributor Author

/test lint

@bkopilov
Add OCI controller implemented with oracle API code.
50a5f40 
This patch allow us decouple terraform code from cluster testing.
Terraform provided by oracle and maintained by them.
Terraform version / code may be updated by oracle .

We run the test same as customer , created support for the next steps:
1. Create a bucket (object-storage)
2. Upload ISO file to the object-storage bucket
3. Create pre authenticated - return ISO download link from OCI storage
4. Create a stack , declare the provision configuration.
5. Upload infrastructure zip file to the stack and set terraform variable
6. Start running job creating oci nodes discovered by redhat cluster and return terraform output files
7. Once nodes are discovered we configure manifest return in openshift#6

We handle cleanup on teardown , running destory .
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, bkopilov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 29, 2024

@bkopilov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-assisted-kube-api-late-binding-single-node 50a5f40 link false /test e2e-metal-assisted-kube-api-late-binding-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adriengentil
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8ee32ff into openshift:master Oct 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriengentil adriengentil adriengentil approved these changes

@eliorerz eliorerz Awaiting requested review from eliorerz

@omertuc omertuc Awaiting requested review from omertuc

@danmanor danmanor Awaiting requested review from danmanor

Assignees

@adriengentil adriengentil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkopilov @adriengentil @rccrdpccl @openshift-ci-robot