cnf ran: Add siteconfig operator pod restart and cluster instance delete tests #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaskosk
reviewed
Sep 13, 2024
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
2 times, most recently
from
6388573
to
6db3323
Compare
klaskosk
reviewed
Sep 19, 2024
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
from
6db3323
to
6c94c95
Compare
klaskosk
reviewed
Sep 19, 2024
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
2 times, most recently
from
165e3a7
to
adfa642
Compare
mpmaruthu
changed the title
mpmaruthu
changed the title
klaskosk
reviewed
Sep 20, 2024
mpmaruthu
changed the title
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
3 times, most recently
from
5a6640a
to
5e85452
Compare
mpmaruthu
changed the title
mpmaruthu
changed the title
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
2 times, most recently
from
39d27e3
to
0cb9f80
Compare
mpmaruthu
changed the title
klaskosk
reviewed
Sep 25, 2024
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
from
0cb9f80
to
fe7afdc
Compare
klaskosk
reviewed
Sep 26, 2024
.golangci.yml
Outdated
| @@ -141,7 +141,6 @@ linters: | |||
| - unparam | |||
| - unused | |||
| - varnamelen | |||
| - wsl | |||
There was a problem hiding this comment.
please remove this change to the lint config too
There was a problem hiding this comment.
Updated, Thanks!
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
from
fe7afdc
to
2c14f51
Compare
|
LGTM. |
josclark42
previously approved these changes
Sep 27, 2024
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
from
2c14f51
to
dbe45c7
Compare
|
@klaskosk . @josclark42 , I have updated this PR with minor changes and added additional test validation check points to improve and make the test automation code more robust. Thanks! The reason for changes - I tried to do final check today by running "dry-run" before merging this PR and then found the change is needed. |
mpmaruthu
force-pushed
the
cnf-ocp-75376
branch
from
dbe45c7
to
673d822
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcornea , @klaskosk , Please review this PR when you have a time.
cc: @yliu127 , @dgonyier
Thanks.
/Peri M
Adding siteconfig-operator test case - OCP-75374
Adding siteconfig-operator test case - OCP-75376
Adding siteconfig-operator test case OCP-75411
Sample test configuration for your reference:
http://registry.kni-qe-0.lab.eng.rdu2.redhat.com:3000/kni-qe/ztp-site-configs/src/helix54+helix77-4.17/siteconfig/ztp-test/siteconfig-operator/detach-ai-sno/kustomization.yaml#L4
Manual test logs:-
Test case 1: https://docs.google.com/document/d/1ihBMjxsZmi2RRX90f5a--vmqzb0hDUxWQIlK4t8Wugk/edit?usp=sharing
Test case 2: https://docs.google.com/document/d/1FsTuWvS0UGaCujsfy5UQRJIlU69T2TdbGJ6Jt6OFANA/edit?usp=sharing
Test case 3: https://docs.google.com/document/d/1luC2QAEUHslWQ136ZvZXwODm38oLV-gFAmwOOwLTMP4/edit?usp=sharing