cnf network: add qinq second PR multi-cvlans #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlguerrero12
reviewed
Jun 3, 2024
| annotation = defineNetworkAnnotation(srIovNetworkDot1Q, nadCVLAN101, true) | ||
| serverDotQPod := createServerTestPod(serverNameDot1q, workerNodeList[0].Definition.Name, testCmdNet2, | ||
| annotation) | ||
| By("Define and create a 802.1AD client container") |
There was a problem hiding this comment.
this should be .1Q, right?
mlguerrero12
reviewed
Jun 3, 2024
|
|
||
| By("Validate that the TCP traffic is double tagged") | ||
| readAndValidateTCPDump(tcpDumpContainer, tcpDumpReadFileCMD, tcpDumpDot1QOutput) | ||
| }) | ||
|
|
||
| It("Verify network traffic over a double tagging QinQ tunnel with multiple C-VLANs using the same S-VLAN", |
There was a problem hiding this comment.
double tagging QinQ is too general - it's better 802.1q/802.1q or two times 802.1q
There was a problem hiding this comment.
How about double tagged 802.1Q ? If so I will update the other times it appears in all the test cases
|
/lgtm |
evgenLevin
reviewed
Jun 3, 2024
| serverIPAddressesNet2 []string | ||
| serverIPAddressesNet3 []string | ||
| clientIPAddressesNet2 []string | ||
| clientIPAddressesNet3 []string |
There was a problem hiding this comment.
replace by
serverIPAddressesNet2 = []string{serverIPV4IP.String(), serverIPV6IP.String()}
serverIPAddressesNet3 = []string{serverIPV4IP2.String(), serverIPV6IP2.String()}
clientIPAddressesNet2 = []string{tsparams.ClientIPv4IPAddress, tsparams.ClientIPv6IPAddress}
clientIPAddressesNet3 = []string{tsparams.ClientIPv6IPAddress2, tsparams.ClientIPv6IPAddress2}
|
/lgtm |
evgenLevin
approved these changes
Jun 4, 2024
|
lgtm |
ajaggapa
approved these changes
Jun 4, 2024
ajaggapa
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding 4 test cases.
2 multi-cvlans
1 negative test
1 simultaneous 802.1ad and 802.1q